From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: claudio.bley@gmail.com (Claudio Bley) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Wed, 09 Mar 2011 22:26:01 +0100 Message-ID: <87fwqw0yvq.wl%claudio.bley@gmail.com> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87sjuywav2.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1299705991 28384 80.91.229.12 (9 Mar 2011 21:26:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Mar 2011 21:26:31 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 09 22:26:26 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PxQtl-0005PU-BB for ged-emacs-devel@m.gmane.org; Wed, 09 Mar 2011 22:26:26 +0100 Original-Received: from localhost ([127.0.0.1]:38108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxQtj-0007Ik-GJ for ged-emacs-devel@m.gmane.org; Wed, 09 Mar 2011 16:26:23 -0500 Original-Received: from [140.186.70.92] (port=47589 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxQte-0007I9-ET for emacs-devel@gnu.org; Wed, 09 Mar 2011 16:26:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxQtd-0002hq-0o for emacs-devel@gnu.org; Wed, 09 Mar 2011 16:26:18 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:38450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxQtc-0002hI-MK for emacs-devel@gnu.org; Wed, 09 Mar 2011 16:26:16 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PxQta-0005K2-GJ for emacs-devel@gnu.org; Wed, 09 Mar 2011 22:26:14 +0100 Original-Received: from dslb-188-106-012-040.pools.arcor-ip.net ([188.106.12.40]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Mar 2011 22:26:14 +0100 Original-Received: from claudio.bley by dslb-188-106-012-040.pools.arcor-ip.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Mar 2011 22:26:14 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 44 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: dslb-188-106-012-040.pools.arcor-ip.net In-Reply-To: <87sjuywav2.fsf@lifelogs.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/23.1 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Mail-Copies-To: never X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137002 Archived-At: At Mon, 07 Mar 2011 21:26:57 -0600, Ted Zlatanov wrote: > > [1 ] > On Sun, 06 Mar 2011 16:16:34 +0100 claudio.bley@gmail.com (Claudio Bley) wrote: > > CB> Please find attached a patch which makes building Emacs with GnuTLS > CB> support on Woe32 possible. > > Claudio, thanks so much for looking at this. My C is very rusty and I > appreciate all your help. I also don't know GnuTLS very well so your > insight is very good. Thank you so much for your encouraging words, but I thought you would be the expert in GnuTLS + Emacs business.. :) > I'll comment and at the end will show my own work on verification and > callbacks. Whatever I don't comment, assume it's excellent :) I hope > you can take what I've done, which is much less capable than your patch, > and bring it into yours to improve the GnuTLS support on all platforms. I'll take a look at your patch when I find the time. > CB> +2011-03-06 Claudio Bley > CB> + > CB> + * starttls.el (starttls-negotiate-gnutls, starttls-open-stream-gnutls): > CB> + Check for builtin GnuTLS support and use it if available. > CB> + > > I think this should be optional. GnuTLS locks up Emacs hard with > concurrent connections (see Lars' email about that from earlier this > week on emacs-devel). Also I intentionally made gnutls.el a separate > file to avoid overriding starttls.el. It shouldn't just take over the > starttls.el functionality. There are too many parameters and no way to > tune them right now; starttls.el is not tunable at all. > But it's good to have a way to just swap all the starttls.el > functionality for gnutls.el functionality, for testing and for brave > users, so I'm OK with making it optional. Having thought about that twice I second that. I'll probably write some defadvice to that matter. - Claudio