From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sam Steingold Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109160: * lisp/vc/vc-dispatcher.el (vc-compilation-mode): Add, based on Date: Thu, 19 Jul 2012 22:09:10 -0400 Organization: disorganization Message-ID: <87fw8n18vt.fsf@gnu.org> References: Reply-To: sds@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342750175 7763 80.91.229.3 (20 Jul 2012 02:09:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2012 02:09:35 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 20 04:09:35 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ss2eq-0006yM-88 for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2012 04:09:32 +0200 Original-Received: from localhost ([::1]:41434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss2ep-00005r-Ac for ged-emacs-devel@m.gmane.org; Thu, 19 Jul 2012 22:09:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss2em-00005W-9j for emacs-devel@gnu.org; Thu, 19 Jul 2012 22:09:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ss2ek-0003wX-Ty for emacs-devel@gnu.org; Thu, 19 Jul 2012 22:09:28 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:42510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ss2ek-0003wI-Mk for emacs-devel@gnu.org; Thu, 19 Jul 2012 22:09:26 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ss2ej-0006qv-Iw for emacs-devel@gnu.org; Fri, 20 Jul 2012 04:09:25 +0200 Original-Received: from cl-pat-tr.clearspring.com ([8.18.54.254]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Jul 2012 04:09:25 +0200 Original-Received: from sds by cl-pat-tr.clearspring.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Jul 2012 04:09:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cl-pat-tr.clearspring.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Cancel-Lock: sha1:uamYB7RxgGEm2Pbh67KpfcXfuR8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151771 Archived-At: > * Stefan Monnier [2012-07-19 18:00:44 -0400]: > > Could you explain this patch? it extends the existing vc-bzr functionality to git & hg. > I do not understand what it's trying to do. Using compilation-mode on > the output of those tools doesn't sound very useful. What's the > use-case? C-x v d emacs/trunk RET lands you in a *vc-dir* buffer + starts vc-pull (running "bzr update") and creates a *vc-bzr* buffer with the command output. putting it in the compilation-mode gives us 2 features: -- one can use 'q' and 'z' to get rid of it -- one can click on a file listed by bzr as modified and the file is visited. >> + (let* ((error-regexp-alist >> + (vc-make-backend-sym backend 'error-regexp-alist)) >> + (compilation-error-regexp-alist >> + (and (boundp error-regexp-alist) >> + (symbol-value error-regexp-alist)))) > > This is clearly wrong: error-regexp-alist seems to be meant to hold a > symbol, but its name implies it should hold an alist. it's a symbol whose value is an alist. yes, you might argue that it should have been named error-regexp-alist-symbol -- Sam Steingold (http://sds.podval.org/) on Ubuntu 12.04 (precise) X 11.0.11103000 http://www.childpsy.net/ http://think-israel.org http://memri.org http://palestinefacts.org http://camera.org http://americancensorship.org Lisp suffers from being twenty or thirty years ahead of time.