From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Derek Upham Newsgroups: gmane.emacs.devel Subject: Re: read_char() does not detect, handle special-event-map buffer changes Date: Fri, 08 Feb 2013 07:32:35 -0800 Message-ID: <87fw16254c.fsf@priss.frightenedpiglet.com> References: <87r4kwjx11.fsf@priss.frightenedpiglet.com> <87lib01vlp.fsf@priss.frightenedpiglet.com> <87k3qk18m6.fsf@priss.frightenedpiglet.com> <87haln1ks1.fsf@priss.frightenedpiglet.com> <87k3qjcl72.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360337569 16386 80.91.229.3 (8 Feb 2013 15:32:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Feb 2013 15:32:49 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: "Michael Albinus" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 16:33:10 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U3pws-0002NQ-5b for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2013 16:33:10 +0100 Original-Received: from localhost ([::1]:56395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3pwZ-00052Z-1u for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2013 10:32:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3pwW-00052U-Bz for emacs-devel@gnu.org; Fri, 08 Feb 2013 10:32:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U3pwU-0004nl-By for emacs-devel@gnu.org; Fri, 08 Feb 2013 10:32:48 -0500 Original-Received: from smtp61.avvanta.com ([206.124.128.61]:53133 helo=mail.avvanta.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3pwU-0004nS-5o for emacs-devel@gnu.org; Fri, 08 Feb 2013 10:32:46 -0500 Original-Received: from mail.avvanta.com (localhost.rowlf.p [127.0.0.1]) by mail.avvanta.com (Postfix) with ESMTP id 1C4C493C5A; Fri, 8 Feb 2013 07:32:44 -0800 (PST) Original-Received: from priss.frightenedpiglet.com (c-24-16-15-52.hsd1.wa.comcast.net [24.16.15.52]) by mail.avvanta.com (Postfix) with ESMTP id 02D6893C44; Fri, 8 Feb 2013 07:32:44 -0800 (PST) Original-Received: from localhost ([127.0.0.1] helo=priss.frightenedpiglet.com) by priss with esmtp (Exim 4.80) (envelope-from ) id 1U3pwJ-0007UM-9Y; Fri, 08 Feb 2013 07:32:35 -0800 User-agent: mu4e 0.9.9.5-dev6; emacs 24.2.2 In-reply-to: <87k3qjcl72.fsf@gmx.de> X-BlargAV-Status: No viruses detected, BlargAV v1.1 on localhost.scooter.p.blarg.net X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 206.124.128.61 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156889 Archived-At: Michael Albinus writes: > Derek Upham writes: > >> This removes a flawed optimization and returns a documented value. It >> doesn't touch read_key_sequence, so that risk goes away. If we were >> getting special events at a high rate of speed this /might/ cause a >> slowdown, but nothing in the special events table seems to be used that >> way---and I expect that the extra time spent popping back up to >> read_key_sequence for the retry will still be very fast compared to the >> time spent in the Emacs Lisp callback. > > I don't know what you mean with "high rate of speed", but special events > are used for D-Bus and for file notifications. There could be a burst of > incoming events, temporarily. A couple of emails back I put in a D-Bus handler for asynchronous messages. I'll set it up to do nothing but push a timestamp onto a list. Then with a couple of dbus-send instances I can look for rate differences between the two code paths. I should have numbers this weekend. Derek -- Derek Upham sand@blarg.net