* Problems with emacs 25 (master branch)
@ 2014-10-10 11:00 Cédric Chépied
2014-10-10 12:12 ` Tassilo Horn
0 siblings, 1 reply; 12+ messages in thread
From: Cédric Chépied @ 2014-10-10 11:00 UTC (permalink / raw)
To: emacs-devel; +Cc: Cédric Chépied
Hi,
I updated my master branch yesterday and this morning I got some bad surprises.
I can't open my org agenda anymore (diary is retrieved with tramp):
Tramp: Inserting `/ssh:*************/.diary'...done
diary-list-entries: Symbol's function definition is void: fancy-diary-display
And then it just displays:
Week-agenda (W41):
In the *Org Agenda* buffer
Newsticker also has problems:
if: Symbol's value as variable is void: newsticker--download-logos [2 times]
It does not display any images anymore (I'm using w3m as HTML renderer). This is
very annoying for news which are only images:
http://piratesourcil.blogspot.com/feeds/posts/default ).
I can open the news in w3m and see images.
Are my problems bugs or just configuration problems?
Thanks,
--
Cédric Chépied
<cedric.chepied@gmail.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 11:00 Problems with emacs 25 (master branch) Cédric Chépied
@ 2014-10-10 12:12 ` Tassilo Horn
2014-10-10 12:41 ` Thierry Volpiatto
0 siblings, 1 reply; 12+ messages in thread
From: Tassilo Horn @ 2014-10-10 12:12 UTC (permalink / raw)
To: Cédric Chépied; +Cc: emacs-devel
Cédric Chépied <cedric.chepied@gmail.com> writes:
Hi Cédric,
> I updated my master branch yesterday and this morning I got some bad
> surprises.
>
> I can't open my org agenda anymore (diary is retrieved with tramp):
> Tramp: Inserting `/ssh:*************/.diary'...done
> diary-list-entries: Symbol's function definition is void: fancy-diary-display
>
> And then it just displays:
> Week-agenda (W41):
> In the *Org Agenda* buffer
It seems `fancy-diary-display' has been renamed to
`diary-fancy-display'. In your config, you probably have
(setq diary-display-function 'fancy-diary-display)
and now you need to use
(setq diary-display-function 'diary-fancy-display)
Or even better, you can just delete it from your configuration since
that's the default value with Emacs 25.
> Newsticker also has problems:
> if: Symbol's value as variable is void: newsticker--download-logos [2 times]
> It does not display any images anymore (I'm using w3m as HTML renderer). This is
In the current newsticker.el there's no `newsticker--download-logos'
variable. Probably that has been renamed to
`newsticker-download-images'. However, setting a non-existent variable
in your config won't have any effects, so I'm not sure if it's your
fault or it is wrong in the emacs version you are using. At least the
current newsticker.el looks correct.
What you can do is M-x toggle-debug-on-error RET and reproduce the error
above. That will show a buffer with a backtrace which you can post
here.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 12:12 ` Tassilo Horn
@ 2014-10-10 12:41 ` Thierry Volpiatto
2014-10-10 13:31 ` Cédric Chépied
2014-10-10 14:10 ` Marco Wahl
0 siblings, 2 replies; 12+ messages in thread
From: Thierry Volpiatto @ 2014-10-10 12:41 UTC (permalink / raw)
To: emacs-devel
Tassilo Horn <tsdh@gnu.org> writes:
>
> It seems `fancy-diary-display' has been renamed to
> `diary-fancy-display'. In your config, you probably have
>
> (setq diary-display-function 'fancy-diary-display)
>
> and now you need to use
>
> (setq diary-display-function 'diary-fancy-display)
>
> Or even better, you can just delete it from your configuration since
> that's the default value with Emacs 25.
Org in emacs-25 is still using `fancy-diary-display', see the function
`org-get-entries-from-diary' and because the alias have been removed,
org-agenda is broken...
So this is a bug in `org-get-entries-from-diary'.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 12:41 ` Thierry Volpiatto
@ 2014-10-10 13:31 ` Cédric Chépied
2014-10-10 13:36 ` Tassilo Horn
2014-10-10 20:23 ` Ulf Jasper
2014-10-10 14:10 ` Marco Wahl
1 sibling, 2 replies; 12+ messages in thread
From: Cédric Chépied @ 2014-10-10 13:31 UTC (permalink / raw)
To: emacs-devel
At Fri, 10 Oct 2014 14:41:19 +0200,
Thierry Volpiatto wrote:
>
> Org in emacs-25 is still using `fancy-diary-display', see the function
> `org-get-entries-from-diary' and because the alias have been removed,
> org-agenda is broken...
>
> So this is a bug in `org-get-entries-from-diary'.
You are right, there is no reference to fancy-diary-display in my configuration
Tassilo Horn <tsdh@gnu.org> wrote:
>
> In the current newsticker.el there's no `newsticker--download-logos'
> variable. Probably that has been renamed to
> `newsticker-download-images'. However, setting a non-existent variable
> in your config won't have any effects, so I'm not sure if it's your
> fault or it is wrong in the emacs version you are using. At least the
> current newsticker.el looks correct.
I found the problem in my configuration and logos are now downloaded without
error. But newsticker still doesn't display images inside news. I tried to
customize newsticker group but I couldn't find something related to this.
--
Cédric Chépied
<cedric.chepied@gmail.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 13:31 ` Cédric Chépied
@ 2014-10-10 13:36 ` Tassilo Horn
2014-10-10 20:23 ` Ulf Jasper
1 sibling, 0 replies; 12+ messages in thread
From: Tassilo Horn @ 2014-10-10 13:36 UTC (permalink / raw)
To: Cédric Chépied; +Cc: emacs-devel
Cédric Chépied <cedric.chepied@gmail.com> writes:
>> In the current newsticker.el there's no `newsticker--download-logos'
>> variable. Probably that has been renamed to
>> `newsticker-download-images'. However, setting a non-existent
>> variable in your config won't have any effects, so I'm not sure if
>> it's your fault or it is wrong in the emacs version you are using.
>> At least the current newsticker.el looks correct.
>
> I found the problem in my configuration and logos are now downloaded
> without error. But newsticker still doesn't display images inside
> news. I tried to customize newsticker group but I couldn't find
> something related to this.
Sorry, I actually don't use newsticker.el so I'm of no help here.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 13:31 ` Cédric Chépied
2014-10-10 13:36 ` Tassilo Horn
@ 2014-10-10 20:23 ` Ulf Jasper
2014-10-13 11:30 ` Cédric Chépied
1 sibling, 1 reply; 12+ messages in thread
From: Ulf Jasper @ 2014-10-10 20:23 UTC (permalink / raw)
To: Cédric Chépied; +Cc: emacs-devel
Cédric Chépied <cedric.chepied@gmail.com> writes:
> I found the problem in my configuration and logos are now downloaded without
> error. But newsticker still doesn't display images inside news. I tried to
> customize newsticker group but I couldn't find something related to this.
I cannot reproduce that with
newsticker-html-renderer is a variable defined in `newst-reader.el'.
Its value is w3m-region
Could you please provide a recipe for reproducing, starting from
'emacs-Q'.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 20:23 ` Ulf Jasper
@ 2014-10-13 11:30 ` Cédric Chépied
0 siblings, 0 replies; 12+ messages in thread
From: Cédric Chépied @ 2014-10-13 11:30 UTC (permalink / raw)
To: emacs-devel
At Fri, 10 Oct 2014 22:23:01 +0200,
Ulf Jasper wrote:
> Could you please provide a recipe for reproducing, starting from
> 'emacs-Q'.
With emacs -Q it works so there is no bug.
The problem was w3m-image-no-idle-timer which was set to t. I did this because
it used to stop downloading big images when in newsticker. Now it seems to work,
even with big images.
Thanks for the help.
--
Cédric Chépied
<cedric.chepied@gmail.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Problems with emacs 25 (master branch)
2014-10-10 12:41 ` Thierry Volpiatto
2014-10-10 13:31 ` Cédric Chépied
@ 2014-10-10 14:10 ` Marco Wahl
2014-10-10 16:13 ` Michael Heerdegen
1 sibling, 1 reply; 12+ messages in thread
From: Marco Wahl @ 2014-10-10 14:10 UTC (permalink / raw)
To: emacs-devel
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Tassilo Horn <tsdh@gnu.org> writes:
>
>>
>> It seems `fancy-diary-display' has been renamed to
>> `diary-fancy-display'. In your config, you probably have
>>
>> (setq diary-display-function 'fancy-diary-display)
>>
>> and now you need to use
>>
>> (setq diary-display-function 'diary-fancy-display)
>>
>> Or even better, you can just delete it from your configuration since
>> that's the default value with Emacs 25.
>
> Org in emacs-25 is still using `fancy-diary-display', see the function
> `org-get-entries-from-diary' and because the alias have been removed,
> org-agenda is broken...
>
> So this is a bug in `org-get-entries-from-diary'.
Thanks for the hint. I will propose a corresponding patch to the Org list.
Concretely:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index da7993c..5fd9fbc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5112,8 +5112,10 @@ of what a project is and how to check if it stuck, customize the variable
"Get the (Emacs Calendar) diary entries for DATE."
(require 'diary-lib)
(let* ((diary-fancy-buffer "*temporary-fancy-diary-buffer*")
- (diary-display-hook '(fancy-diary-display))
- (diary-display-function 'fancy-diary-display)
+ (diary-display-function (if (version< emacs-version "25")
+ 'fancy-diary-display
+ 'diary-fancy-display))
+ (diary-display-hook '(diary-display-function))
(pop-up-frames nil)
(diary-list-entries-hook
(cons 'org-diary-default-entry diary-list-entries-hook))
--8<---------------cut here---------------end--------------->8---
Ciao, Marco
--
http://www.wahlzone.de
PGP: 0x0A3AE6F2
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-10-13 12:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 11:00 Problems with emacs 25 (master branch) Cédric Chépied
2014-10-10 12:12 ` Tassilo Horn
2014-10-10 12:41 ` Thierry Volpiatto
2014-10-10 13:31 ` Cédric Chépied
2014-10-10 13:36 ` Tassilo Horn
2014-10-10 20:23 ` Ulf Jasper
2014-10-13 11:30 ` Cédric Chépied
2014-10-10 14:10 ` Marco Wahl
2014-10-10 16:13 ` Michael Heerdegen
2014-10-11 11:05 ` Marco Wahl
2014-10-13 12:54 ` Cédric Chépied
2014-10-13 12:58 ` Michael Heerdegen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).