From: Oleh Krehel <ohwoeowho@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Is INLINE_HEADER_BEGIN still useful?
Date: Wed, 29 Apr 2015 17:33:03 +0200 [thread overview]
Message-ID: <87fv7jkl00.fsf@gmail.com> (raw)
In-Reply-To: <5540F3BC.4070905@cs.ucla.edu> (Paul Eggert's message of "Wed, 29 Apr 2015 08:07:40 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> Oleh Krehel wrote:
>> I got no warnings when I tested my buffer.h patch.
>
> Try './configure --enable-gcc-warnings'. Certainly the warnings do
> appear on some modern GCC implementations -- otherwise we wouldn't
> have gone to all that work to suppress them so recently.
OK, but that just makes each warning into an error. My build terminates
for unused variable "spool_name", which is unused because I don't have
the right configuration.
>> Maybe someone on the list
>> could respond if they use a compiler that doesn't support the C99
>> "inline" declaration?
>
> It's not as simple as that. Although most compilers have grokked the
> 'inline' keyword for some time, this does not imply full support for
> C99 'inline' everywhere. For example, OS X 10.8's standard headers do
> not work when used by extern inline functions, so Emacs can't simply
> assume C99 inline will work on this relatively recent platform
> (released July 2012 and still in wide use).
Not all inline are extern inline, buffer.h doesn't need to be extern
inline, if I understand correctly. But anyway, if you say it's needed,
it's needed.
One more question, is there a list of platforms on which Emacs is known
to build fine, by version? Maybe 25.1 doesn't build on OS X 10.8 for
reasons other than C99 compatibility.
Oleh
next prev parent reply other threads:[~2015-04-29 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 11:21 Is INLINE_HEADER_BEGIN still useful? Oleh Krehel
2015-04-29 14:00 ` Paul Eggert
2015-04-29 14:12 ` Oleh Krehel
2015-04-29 15:07 ` Paul Eggert
2015-04-29 15:33 ` Oleh Krehel [this message]
2015-04-29 17:54 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv7jkl00.fsf@gmail.com \
--to=ohwoeowho@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).