* Re: master 12629d2: Implement w32notify-valid-p [not found] ` <E1ZbNnC-0003wf-NG@vcs.savannah.gnu.org> @ 2015-09-14 7:33 ` Michael Albinus 2015-09-14 7:39 ` Eli Zaretskii 0 siblings, 1 reply; 8+ messages in thread From: Michael Albinus @ 2015-09-14 7:33 UTC (permalink / raw) To: emacs-devel; +Cc: Eli Zaretskii Eli Zaretskii <eliz@gnu.org> writes: > +DEFUN ("w32notify-valid-p", Fw32notify_valid_p, Sw32notify_valid_p, 1, 1, 0, > + doc: /* "Check a watch specified by its WATCH-DESCRIPTOR for validity. > + > +WATCH-DESCRIPTOR should be an object returned by `w32notify-add-watch'. > + > +A watch can become invalid if the directory it watches is deleted, or if > +the watcher thread exits abnormally for any other reason. */) I believe a watch will also be invalid after calling `w32notify-rm-watch'. Maybe it could be mentioned. Best regards, Michael. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:33 ` master 12629d2: Implement w32notify-valid-p Michael Albinus @ 2015-09-14 7:39 ` Eli Zaretskii 2015-09-14 7:41 ` Michael Albinus 0 siblings, 1 reply; 8+ messages in thread From: Eli Zaretskii @ 2015-09-14 7:39 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel > From: Michael Albinus <michael.albinus@gmx.de> > Cc: Eli Zaretskii <eliz@gnu.org> > Date: Mon, 14 Sep 2015 09:33:33 +0200 > > Eli Zaretskii <eliz@gnu.org> writes: > > > +DEFUN ("w32notify-valid-p", Fw32notify_valid_p, Sw32notify_valid_p, 1, 1, 0, > > + doc: /* "Check a watch specified by its WATCH-DESCRIPTOR for validity. > > + > > +WATCH-DESCRIPTOR should be an object returned by `w32notify-add-watch'. > > + > > +A watch can become invalid if the directory it watches is deleted, or if > > +the watcher thread exits abnormally for any other reason. */) > > I believe a watch will also be invalid after calling `w32notify-rm-watch'. > Maybe it could be mentioned. It isn't mentioned in the inotify doc string. And it's self-evident, I think. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:39 ` Eli Zaretskii @ 2015-09-14 7:41 ` Michael Albinus 2015-09-14 7:48 ` Eli Zaretskii 2015-09-14 9:25 ` David Kastrup 0 siblings, 2 replies; 8+ messages in thread From: Michael Albinus @ 2015-09-14 7:41 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > It isn't mentioned in the inotify doc string. Right. My bad. > And it's self-evident, I think. For sure. But I'm a pedantic German :-( Best regards, Michael. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:41 ` Michael Albinus @ 2015-09-14 7:48 ` Eli Zaretskii 2015-09-14 7:50 ` Michael Albinus 2015-09-14 9:25 ` David Kastrup 1 sibling, 1 reply; 8+ messages in thread From: Eli Zaretskii @ 2015-09-14 7:48 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel > From: Michael Albinus <michael.albinus@gmx.de> > Cc: emacs-devel@gnu.org > Date: Mon, 14 Sep 2015 09:41:19 +0200 > > Eli Zaretskii <eliz@gnu.org> writes: > > > It isn't mentioned in the inotify doc string. > > Right. My bad. > > > And it's self-evident, I think. > > For sure. But I'm a pedantic German :-( I'm okay with adding that information to all the back-ends. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:48 ` Eli Zaretskii @ 2015-09-14 7:50 ` Michael Albinus 2015-09-14 9:43 ` Eli Zaretskii 0 siblings, 1 reply; 8+ messages in thread From: Michael Albinus @ 2015-09-14 7:50 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > I'm okay with adding that information to all the back-ends. Thanks! Looks like I'm responsible for all of them but w32notify.c Best regards, Michael. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:50 ` Michael Albinus @ 2015-09-14 9:43 ` Eli Zaretskii 2015-09-14 20:16 ` Michael Albinus 0 siblings, 1 reply; 8+ messages in thread From: Eli Zaretskii @ 2015-09-14 9:43 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel > From: Michael Albinus <michael.albinus@gmx.de> > Cc: emacs-devel@gnu.org > Date: Mon, 14 Sep 2015 09:50:34 +0200 > > Eli Zaretskii <eliz@gnu.org> writes: > > > I'm okay with adding that information to all the back-ends. > > Thanks! Looks like I'm responsible for all of them but w32notify.c I fixed w32notify-valid-p's doc string. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 9:43 ` Eli Zaretskii @ 2015-09-14 20:16 ` Michael Albinus 0 siblings, 0 replies; 8+ messages in thread From: Michael Albinus @ 2015-09-14 20:16 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > I fixed w32notify-valid-p's doc string. Also fixed for inotify-valid-p. Best regards, Michael. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master 12629d2: Implement w32notify-valid-p 2015-09-14 7:41 ` Michael Albinus 2015-09-14 7:48 ` Eli Zaretskii @ 2015-09-14 9:25 ` David Kastrup 1 sibling, 0 replies; 8+ messages in thread From: David Kastrup @ 2015-09-14 9:25 UTC (permalink / raw) To: Michael Albinus; +Cc: Eli Zaretskii, emacs-devel Michael Albinus <michael.albinus@gmx.de> writes: > Eli Zaretskii <eliz@gnu.org> writes: > >> It isn't mentioned in the inotify doc string. > > Right. My bad. > >> And it's self-evident, I think. > > For sure. But I'm a pedantic German :-( That's not as much self-evident as redundant. -- David Kastrup ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-09-14 20:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20150914070310.15131.42474@vcs.savannah.gnu.org> [not found] ` <E1ZbNnC-0003wf-NG@vcs.savannah.gnu.org> 2015-09-14 7:33 ` master 12629d2: Implement w32notify-valid-p Michael Albinus 2015-09-14 7:39 ` Eli Zaretskii 2015-09-14 7:41 ` Michael Albinus 2015-09-14 7:48 ` Eli Zaretskii 2015-09-14 7:50 ` Michael Albinus 2015-09-14 9:43 ` Eli Zaretskii 2015-09-14 20:16 ` Michael Albinus 2015-09-14 9:25 ` David Kastrup
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).