Re: master 12629d2: Implement w32notify-valid-p

Re: master 12629d2: Implement w32notify-valid-p

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

> +DEFUN ("w32notify-valid-p", Fw32notify_valid_p, Sw32notify_valid_p, 1, 1, 0,
> +       doc: /* "Check a watch specified by its WATCH-DESCRIPTOR for validity.
> +
> +WATCH-DESCRIPTOR should be an object returned by `w32notify-add-watch'.
> +
> +A watch can become invalid if the directory it watches is deleted, or if
> +the watcher thread exits abnormally for any other reason.  */)

I believe a watch will also be invalid after calling `w32notify-rm-watch'.
Maybe it could be mentioned.

Best regards, Michael.

Re: master 12629d2: Implement w32notify-valid-p

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 14 Sep 2015 09:33:33 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > +DEFUN ("w32notify-valid-p", Fw32notify_valid_p, Sw32notify_valid_p, 1, 1, 0,
> > +       doc: /* "Check a watch specified by its WATCH-DESCRIPTOR for validity.
> > +
> > +WATCH-DESCRIPTOR should be an object returned by `w32notify-add-watch'.
> > +
> > +A watch can become invalid if the directory it watches is deleted, or if
> > +the watcher thread exits abnormally for any other reason.  */)
> 
> I believe a watch will also be invalid after calling `w32notify-rm-watch'.
> Maybe it could be mentioned.

It isn't mentioned in the inotify doc string.  And it's self-evident,
I think.

Re: master 12629d2: Implement w32notify-valid-p

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

> It isn't mentioned in the inotify doc string.

Right. My bad.

> And it's self-evident, I think.

For sure. But I'm a pedantic German :-(

Best regards, Michael.

Re: master 12629d2: Implement w32notify-valid-p

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: emacs-devel@gnu.org
> Date: Mon, 14 Sep 2015 09:41:19 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It isn't mentioned in the inotify doc string.
> 
> Right. My bad.
> 
> > And it's self-evident, I think.
> 
> For sure. But I'm a pedantic German :-(

I'm okay with adding that information to all the back-ends.

Re: master 12629d2: Implement w32notify-valid-p

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

> I'm okay with adding that information to all the back-ends.

Thanks! Looks like I'm responsible for all of them but w32notify.c

Best regards, Michael.

Re: master 12629d2: Implement w32notify-valid-p

[David Kastrup]

Michael Albinus <michael.albinus@gmx.de> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> It isn't mentioned in the inotify doc string.
>
> Right. My bad.
>
>> And it's self-evident, I think.
>
> For sure. But I'm a pedantic German :-(

That's not as much self-evident as redundant.

-- 
David Kastrup

Re: master 12629d2: Implement w32notify-valid-p

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: emacs-devel@gnu.org
> Date: Mon, 14 Sep 2015 09:50:34 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I'm okay with adding that information to all the back-ends.
> 
> Thanks! Looks like I'm responsible for all of them but w32notify.c

I fixed w32notify-valid-p's doc string.

Re: master 12629d2: Implement w32notify-valid-p

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

> I fixed w32notify-valid-p's doc string.

Also fixed for inotify-valid-p.

Best regards, Michael.