unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleh Krehel <ohwoeowho@gmail.com>
To: Leo Liu <sdl.web@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode?
Date: Wed, 06 Jan 2016 10:14:41 +0100	[thread overview]
Message-ID: <87fuybqdby.fsf@gmail.com> (raw)
In-Reply-To: <m1k2nnipuu.fsf@gmail.com> (Leo Liu's message of "Wed, 06 Jan 2016 07:11:21 +0800")

Hi Leo,

Leo Liu <sdl.web@gmail.com> writes:

> The introduction of (indent 1) to define-minor-mode. I have quite a few
> define-minor-mode instances starting like this:
>
> (define-minor-mode some_fancy_mode nil
>   ...)
>
> The indentation is changed between emacs < 25 and 25.

I added an (indent 1) statement around a year ago. The reason is that it
didn't have one before, and that (indent 1) is obviously the correct
indentation level.

Every `define-minor-mode' statement in the core (and org-mode, and most
of ELPA) already obeys the (intent 1) convention. It seems that you were
defining minor modes in your config (and ELPA) with nil instead of the
docstring. I suggest to either add a docstring or put a newline after
the minor mode name.

Oleh



  reply	other threads:[~2016-01-06  9:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 12:32 Can we not introduce frivolous indentation change to define-minor-mode? Leo Liu
2016-01-05 16:09 ` Eli Zaretskii
2016-01-05 23:11   ` Leo Liu
2016-01-06  9:14     ` Oleh Krehel [this message]
2016-01-06 11:50       ` Leo Liu
2016-01-06 12:38         ` Oleh Krehel
2016-01-06 13:42           ` Artur Malabarba
2016-01-06 13:56             ` Oleh Krehel
2016-01-06 14:33               ` Artur Malabarba
2016-01-06 15:37               ` Jonas Bernoulli
2016-01-06 15:48                 ` Oleh Krehel
2016-01-06 15:54                   ` Dmitry Gutov
2016-01-06 16:02                     ` Oleh Krehel
2016-01-07  1:54                       ` Leo Liu
2016-01-07 16:09                         ` Eli Zaretskii
2016-01-07 17:58                           ` John Wiegley
2016-01-07 18:49                             ` Leo Liu
2016-01-07 19:00                               ` John Wiegley
2016-01-07 19:40                                 ` Leo Liu
2016-01-07 19:05                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuybqdby.fsf@gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).