unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Herring\, Davis" <herring@lanl.gov>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH] Showing the relevant part of a diff
Date: Fri, 19 Feb 2016 16:49:35 +1100	[thread overview]
Message-ID: <87fuwp8d1s.fsf@gnus.org> (raw)
In-Reply-To: <B393F5AD12955C48A84FFB08032CD04F6C432C3C@ECS-EXG-P-MB01.win.lanl.gov> (Davis Herring's message of "Fri, 19 Feb 2016 05:43:23 +0000")

"Herring, Davis" <herring@lanl.gov> writes:

> When looking at changes made to a file, the ones most likely to be
> interesting are those affecting the portion of the file in view.  The
> second attached patch causes `vc-diff' to place point at the place in
> the diff that corresponds to point in the file being compared (only if
> the current source is the endpoint of the diff, of course).

This sounds very useful, I think.

> To resolve:
> 1. Would this need a NEWS entry?

Yes.  And documentation in the manual.

> 2. Does it need to be customizable?  (M-< is all it takes to "recover
> the old behavior"...)

I don't think it has to be customisable.

> 3. Is it worth supporting the (very rare) "normal" diff format?

That would be nice, but it's very rare to see those in the wild these
days, so if it's a lot of work, it may not be worth it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2016-02-19  5:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19  5:43 [PATCH] Showing the relevant part of a diff Herring, Davis
2016-02-19  5:49 ` Lars Ingebrigtsen [this message]
2016-02-19  8:47 ` Eli Zaretskii
2016-02-20 20:20   ` Herring, Davis
2016-02-20 20:39     ` Eli Zaretskii
2016-02-20 22:49       ` Herring, Davis
2016-07-15 21:19         ` Davis Herring
2016-07-16  2:14           ` Herring, Davis
2016-07-16  9:28             ` Dmitry Gutov
2016-07-18 14:15               ` Ted Zlatanov
2016-07-18 23:20                 ` Dmitry Gutov
2016-07-19 14:12                   ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuwp8d1s.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=herring@lanl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).