From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Thu, 07 Jul 2016 14:01:34 +0100 Message-ID: <87furl4n69.fsf@russet.org.uk> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <20160707124606.GB4192@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467896526 31228 80.91.229.3 (7 Jul 2016 13:02:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 13:02:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 15:01:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bL8wF-0007sG-8I for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 15:01:55 +0200 Original-Received: from localhost ([::1]:39728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8wE-0007Zd-Gn for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 09:01:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8w0-0007BU-0r for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:01:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL8vw-0000GR-01 for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:01:40 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:36975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8vv-0000GD-Oy for emacs-devel@gnu.org; Thu, 07 Jul 2016 09:01:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=Q7dxN0f+ok+0hz3Zv+caVhqzP+3FGb4AhxDf6cU7Ays=; b=RuP33aQk+1eOvgjRFGwVxLx+dP KtSX0VkrT5rQNv7P8Rr1p2atMuNeE2R8x2RkPWrFnWqGbM6y+lDayIVOuzgxnYkEWfZSJgqh7z3ee esxLK13r/g1vGi/bYYKm8O7y2wK3DPFMNvd8zO7MBsKthvBMFwtgDWat0yOgBa78EuyPWK/YkQGDu STi/s/C6xSoXA8NjK1HcXlQ3J5UZzNB/JlokgiWrflGzmnjsKsfIGTvoEUAwSjw/AT+onncL/nFfG i09Mb19z34nQ0fpjwRq7/jWMq2bMhk2ZiRmmXKq3yyBjNYDgYOLVg+q8GADA3ebVaeqgm0mmAAiPl pUMObs2A==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:32996 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bL8vu-000UIL-Vu; Thu, 07 Jul 2016 14:01:35 +0100 In-Reply-To: <20160707124606.GB4192@acm.fritz.box> (Alan Mackenzie's message of "Thu, 7 Jul 2016 12:46:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205315 Archived-At: Alan Mackenzie writes: > Hello, Ted. > > On Wed, Jul 06, 2016 at 10:20:07AM -0400, Ted Zlatanov wrote: >> On Sun, 06 Mar 2016 13:52:04 -0800 John Wiegley wrote: > > [ .... ] > >> But Emacs doesn't have a pull request contribution system, which makes >> it hard to review things before they go in, so contributors must know >> and follow the right format at all times. It's a pain. > >> So I would suggest moving to a pull request system, where code review >> from a second contributor is required to merge any non-trivial code >> (exceptions should be granted based on years contributing to Emacs). >> That also gives *everyone* the opportunity to comment on the code before >> it's merged, instead of post-facto. Clearly services such as Github and >> BitBucket and many others have been offering this functionality for a >> while with good results. > >> A big advantage of pull requests is that they can group commits, so each >> commit doesn't need the level of detail it does today, and so the >> evolution of the work is visible to a reviewer. > > I don't know exactly what is meant by "pull request" and "pull request > system". I don't think they are established terms. https://en.wikipedia.org/wiki/Distributed_version_control#Pull_requests You send an email saying "here are the changes that I want to incorporate". > The term seems to imply that instead of a contributor pushing a change > from his machine to a central repository, some specially authorised > authority would pull the change from the contributor's machine. This > would seem to imply every contributor needing to set up an scp daemon on > his local machine, which doesn't feel like a Good Thing. On *some* machine, yes. That can be their own server, or a hosted git repository, or a branch on the Emacs git repository. > Please explain "pull request\( system\)?" more precisely. https://en.wikipedia.org/wiki/List_of_tools_for_code_review It keeps a list of all the pull requests coming in. They provide things like inline comments over diffs, threaded conversation, integration with continuous integration. Many of them, once the PR is complete, will automate the merge to master. Phil