* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings [not found] ` <20170320125825.4C92420E17@vcs0.savannah.gnu.org> @ 2017-03-20 13:16 ` Stefan Monnier 2017-03-20 13:27 ` Ted Zlatanov 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2017-03-20 13:16 UTC (permalink / raw) To: emacs-devel; +Cc: Ted Zlatanov > -(eval-when-compile (require 'cl)) > +(eval-when-compile (require 'cl-extra)) Hmm... Why? Normally, the way CL is designed, you should only need to require the `cl` or `cl-lib` thingy, and the internal decomposition into separate files should be hidden from the user via autoloads. Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 13:16 ` [elpa] master 39d163a: load-dir: fix CL and free variable warnings Stefan Monnier @ 2017-03-20 13:27 ` Ted Zlatanov 2017-03-20 13:51 ` Stefan Monnier 0 siblings, 1 reply; 7+ messages in thread From: Ted Zlatanov @ 2017-03-20 13:27 UTC (permalink / raw) To: emacs-devel On Mon, 20 Mar 2017 09:16:33 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: >> -(eval-when-compile (require 'cl)) >> +(eval-when-compile (require 'cl-extra)) SM> Hmm... Why? Normally, the way CL is designed, you should only need to SM> require the `cl` or `cl-lib` thingy, and the internal decomposition into SM> separate files should be hidden from the user via autoloads. I had a user report that `cl-some' wasn't getting loaded with just 'cl. May have been from an older Emacs-- I'm not sure of the Right Way to fix this, so I apologize if I made things worse. What would you recommend? Ted ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 13:27 ` Ted Zlatanov @ 2017-03-20 13:51 ` Stefan Monnier 2017-03-20 14:00 ` Ted Zlatanov 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2017-03-20 13:51 UTC (permalink / raw) To: emacs-devel > I had a user report that `cl-some' wasn't getting loaded with just 'cl. `cl-some` is part of `cl-lib`, not `cl` (nor `cl-extra`). > I'm not sure of the Right Way to fix this, so I apologize if I made > things worse. What would you recommend? Either use `some` instead of `cl-some`, or use `cl-lib` (and add a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's header). Stefan "who favors the `cl-lib` solution" ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 13:51 ` Stefan Monnier @ 2017-03-20 14:00 ` Ted Zlatanov 2017-03-20 14:12 ` Tino Calancha 2017-03-20 14:45 ` Stefan Monnier 0 siblings, 2 replies; 7+ messages in thread From: Ted Zlatanov @ 2017-03-20 14:00 UTC (permalink / raw) To: emacs-devel On Mon, 20 Mar 2017 09:51:07 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: SM> Either use `some` instead of `cl-some`, or use `cl-lib` (and add SM> a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's SM> header). BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":" afterwards. SM> Stefan "who favors the `cl-lib` solution" Like this? I'll commit if you agree. Thanks for the help Ted diff --git a/packages/load-dir/load-dir.el b/packages/load-dir/load-dir.el index ab88ea7..b2231a5 100644 --- a/packages/load-dir/load-dir.el +++ b/packages/load-dir/load-dir.el @@ -9,6 +9,7 @@ ;; Maintainer: Teodor Zlatanov <tzz@lifelogs.com> ;; Version: 0.0.5 ;; Keywords: lisp, files, convenience +;; Package-Requires: ((cl-lib "0.5")) ;; This file is part of GNU Emacs. @@ -43,7 +44,7 @@ ;;; Code: -(eval-when-compile (require 'cl-extra)) +(eval-when-compile (require 'cl-lib)) (defgroup load-dir nil "Automatically load all Emacs Lisp files in given directories." ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 14:00 ` Ted Zlatanov @ 2017-03-20 14:12 ` Tino Calancha 2017-03-20 14:45 ` Stefan Monnier 1 sibling, 0 replies; 7+ messages in thread From: Tino Calancha @ 2017-03-20 14:12 UTC (permalink / raw) To: Ted Zlatanov; +Cc: Tino Calancha, Emacs developers On Mon, 20 Mar 2017, Ted Zlatanov wrote: > On Mon, 20 Mar 2017 09:51:07 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: > > SM> Either use `some` instead of `cl-some`, or use `cl-lib` (and add > SM> a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's > SM> header). > > BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":" > afterwards. > > SM> Stefan "who favors the `cl-lib` solution" > > Like this? I'll commit if you agree. > > Thanks for the help > Ted > > diff --git a/packages/load-dir/load-dir.el b/packages/load-dir/load-dir.el > index ab88ea7..b2231a5 100644 > --- a/packages/load-dir/load-dir.el > +++ b/packages/load-dir/load-dir.el > @@ -9,6 +9,7 @@ > ;; Maintainer: Teodor Zlatanov <tzz@lifelogs.com> > ;; Version: 0.0.5 > ;; Keywords: lisp, files, convenience > +;; Package-Requires: ((cl-lib "0.5")) > > ;; This file is part of GNU Emacs. > > @@ -43,7 +44,7 @@ > > ;;; Code: > > -(eval-when-compile (require 'cl-extra)) > +(eval-when-compile (require 'cl-lib)) ^^^^^^^^^^^^^^^^^^ Just plain `require' because `cl-some' is a defun not a macro: (require 'cl-lib) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 14:00 ` Ted Zlatanov 2017-03-20 14:12 ` Tino Calancha @ 2017-03-20 14:45 ` Stefan Monnier 2017-03-20 15:15 ` Ted Zlatanov 1 sibling, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2017-03-20 14:45 UTC (permalink / raw) To: emacs-devel > BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":" > afterwards. Thanks. Fixed. SM> Stefan "who favors the `cl-lib` solution" > Like this? I'll commit if you agree. Looks good to me (after Tino's fix), thanks, Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings 2017-03-20 14:45 ` Stefan Monnier @ 2017-03-20 15:15 ` Ted Zlatanov 0 siblings, 0 replies; 7+ messages in thread From: Ted Zlatanov @ 2017-03-20 15:15 UTC (permalink / raw) To: emacs-devel On Mon, 20 Mar 2017 10:45:15 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: SM> Looks good to me (after Tino's fix), thanks, On Mon, 20 Mar 2017 23:12:33 +0900 (JST) Tino Calancha <tino.calancha@gmail.com> wrote: TC> Just plain `require' because `cl-some' is a defun not a macro: Thanks for your help, Stefan and Tino. Applied; I hope that settles it. Ted ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-20 15:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170320125824.26461.58778@vcs0.savannah.gnu.org>
[not found] ` <20170320125825.4C92420E17@vcs0.savannah.gnu.org>
2017-03-20 13:16 ` [elpa] master 39d163a: load-dir: fix CL and free variable warnings Stefan Monnier
2017-03-20 13:27 ` Ted Zlatanov
2017-03-20 13:51 ` Stefan Monnier
2017-03-20 14:00 ` Ted Zlatanov
2017-03-20 14:12 ` Tino Calancha
2017-03-20 14:45 ` Stefan Monnier
2017-03-20 15:15 ` Ted Zlatanov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).