From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Mon, 06 Aug 2018 18:41:27 -0600 Message-ID: <87ftzrknyg.fsf@tromey.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533602410 21250 195.159.176.226 (7 Aug 2018 00:40:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2018 00:40:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 02:40:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmq2e-0005NR-1y for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2018 02:40:04 +0200 Original-Received: from localhost ([::1]:36779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmq4k-000752-Nj for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2018 20:42:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmq46-00074x-IH for emacs-devel@gnu.org; Mon, 06 Aug 2018 20:41:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmq41-0004X9-Fu for emacs-devel@gnu.org; Mon, 06 Aug 2018 20:41:34 -0400 Original-Received: from gateway32.websitewelcome.com ([192.185.145.125]:27717) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fmq41-0004Wp-9n for emacs-devel@gnu.org; Mon, 06 Aug 2018 20:41:29 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 50F3314E12D for ; Mon, 6 Aug 2018 19:41:28 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id mq40fH6ZWaSeymq40fpLtF; Mon, 06 Aug 2018 19:41:28 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nWOFEj5l/mU1R1i1IC4E9Dywgts2TGO+yP0WXzCNYog=; b=yKOo5vrtwE9DmVtx4VfLZBoMNQ 4v4rEES4nQLiNSbU9JAUwaTVNPdy85IsmqYLSwbRWQZzo2rQ+kLTLyPfzfPjsqpnPN0MmALG7IPkb Q71Uuy4UXNUUlqO2B8NmE8etZ; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:52956 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fmq3z-00397V-R3; Mon, 06 Aug 2018 19:41:27 -0500 X-Attribution: Tom In-Reply-To: (Andy Moreton's message of "Mon, 06 Aug 2018 19:12:34 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fmq3z-00397V-R3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:52956 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.145.125 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228254 Archived-At: >>>>> "Andy" == Andy Moreton writes: Andy> ok, then maybe XINTEGER would still be useful. Andy> On the bignum branch that code would now be: Andy> if (FIXNATP (foo)) Andy> x = XFASTINT (foo); Andy> Perhaps XFASTINT should be renamed XFIXNAT to be consistent. It's easy to do these kinds of renamings, since it's just a simple "sed -i". So, if Eli or Paul can let me know what they want, I can do it. The main difficulty with these things is that they make the merges more complicated. One idea to simplify this would be to start a new branch just before the merge to trunk, do the renamings there, then cherry-pick the rest of the patches off the current branch. Other ways might also not be too hard; I suppose it depends on what kind of merges are considered ok in Emacs development (I don't know). As far as I know the branch is ready. I have two uncommitted patches: one for dumping (just sent) and one to use mpz_import (that I can't test). The second one seems like a minor improvement and could probably be dropped. Tom