From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7b31de4: Add hook for all events Date: Wed, 23 Jan 2019 23:10:11 +0000 Message-ID: <87fttj55t8.fsf@russet.org.uk> References: <20190122214637.25164.20429@vcs0.savannah.gnu.org> <20190122214639.B2E13203DD@vcs0.savannah.gnu.org> <40f2dac5-f342-b9f0-a792-796a6baf9a56@dancol.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175814"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 00:10:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmRfG-000jYU-23 for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 00:10:34 +0100 Original-Received: from localhost ([127.0.0.1]:43364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmRfE-00075R-Sj for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2019 18:10:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmRf6-00074G-CV for emacs-devel@gnu.org; Wed, 23 Jan 2019 18:10:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmRf0-0003VA-37 for emacs-devel@gnu.org; Wed, 23 Jan 2019 18:10:21 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:49502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmRev-0003T9-Ts for emacs-devel@gnu.org; Wed, 23 Jan 2019 18:10:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fZCoiMohGnwZMO+9AoutLFTmXWZ4JHNUA9DLa9z2PfA=; b=zb/s6Ss8+h1hQpNbSay1cKauq i7xtVcvov7kjKzJEglTsoXBn1hnFZLOZtQgNnmQS0C01KHM9q972S2GZsenfoMlTu4QiN/8y9a9NG Qs71307GVFfdg9PhK3oEBe2bYZweJiKSfAryKIZgdzovRjjTCRE4GvunS6R9fJt3GvpqJVcjhWvXc 3DEG6i7pzbPkD8i6GGGeAzzYhJAW8rftGG5hyVadfXaf9H/BzF7ci27jERWJlZEcvGU7JESI8PXbs HCVPApgPCBL35YGKeqkrpqVDqM+mCc+J8sWQRC9Fn2pCrqa8FrsZXA8LkPGOYsS/5wEKNwDEC9wJr 9e03TaRHQ==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:53536 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gmReu-00AquR-5B; Wed, 23 Jan 2019 23:10:12 +0000 In-Reply-To: <40f2dac5-f342-b9f0-a792-796a6baf9a56@dancol.org> (Daniel Colascione's message of "Tue, 22 Jan 2019 17:30:12 -0800") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232661 Archived-At: Daniel Colascione writes: > On 1/22/19 1:46 PM, Phillip Lord wrote: >> branch: master >> commit 7b31de4d107302ed91ce7519cd778b340a9880ee >> Author: Phillip Lord >> Commit: Phillip Lord >> >> Add hook for all events > > Why? Finally got around to doing this 4 years after I first hit the problem. https://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00742.html Short answer: input methods break completion provided by both company and my own pabbrev. For example, try copying the company-mode documentation into *scratch*, M-x text-mode, M-x company-mode, M-x set-input-method "italian-postfix". Now type "Comple". You should see something like: Compl Complements Complete Completing Completion Complex e_[] where e_ is e underscore and [] is the cursor and the lines in the middle are offered completions. The problem is that company uses pre-command-hook to remove old offered completions. But self-insert hasn't run yet, because the user hasn't decided whether to type "e" or "e'". With this hook, I can pick up the intermediate keypresses. Does it cause any problems you can foresee (other than signally a lot). Phil