From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding Date: Sat, 18 May 2019 10:10:09 +0200 Organization: GNU Message-ID: <87ftpc2nfi.fsf@bzg.fr> References: <20190515175318.10237.53148@vcs0.savannah.gnu.org> <20190515175319.ACE4B20537@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="136373"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 10:10:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRuQC-000ZLs-68 for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 10:10:24 +0200 Original-Received: from localhost ([127.0.0.1]:59185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRuQB-0001P9-4c for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 04:10:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRuPz-0001MW-Gk for emacs-devel@gnu.org; Sat, 18 May 2019 04:10:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRuPz-0004Wx-FX; Sat, 18 May 2019 04:10:11 -0400 Original-Received: from [2a01:e35:2fe1:f780:19e0:6351:4137:7428] (port=37438 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1hRuPy-0001FY-RM; Sat, 18 May 2019 04:10:11 -0400 Original-Received: by guerry (Postfix, from userid 1000) id 886391A60BE8; Sat, 18 May 2019 10:10:09 +0200 (CEST) In-Reply-To: (Andy Moreton's message of "Fri, 17 May 2019 19:15:54 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236707 Archived-At: Hi Andy and Stefan, Andy Moreton writes: > On Fri 17 May 2019, Stefan Monnier wrote: > >>> Indeed, thanks. Does the patch below work for you? >> >> I meant this one, >> >> Stefan > > That works in my setup, which uses the ?V format (I haven't > tested the others). I use %G and there is a missing (defvar gnus-tmp-name) in gnus-sum.el. Shall I just go ahead an add this? diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 556fb63a07..31958ff7b0 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -42,6 +42,7 @@ gnus-tmp-header (defvar gnus-tmp-indentation) (defvar gnus-tmp-level) (defvar gnus-tmp-lines) +(defvar gnus-tmp-name) (defvar gnus-tmp-number) (defvar gnus-tmp-opening-bracket) (defvar gnus-tmp-process) -- Bastien