From: Bastien <bzg@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding
Date: Sat, 18 May 2019 10:10:09 +0200 [thread overview]
Message-ID: <87ftpc2nfi.fsf@bzg.fr> (raw)
In-Reply-To: <vz1sgtdlzfp.fsf@gmail.com> (Andy Moreton's message of "Fri, 17 May 2019 19:15:54 +0100")
Hi Andy and Stefan,
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Fri 17 May 2019, Stefan Monnier wrote:
>
>>> Indeed, thanks. Does the patch below work for you?
>>
>> I meant this one,
>>
>> Stefan
>
> That works in my setup, which uses the ?V format (I haven't
> tested the others).
I use %G and there is a missing (defvar gnus-tmp-name) in gnus-sum.el.
Shall I just go ahead an add this?
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 556fb63a07..31958ff7b0 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -42,6 +42,7 @@ gnus-tmp-header
(defvar gnus-tmp-indentation)
(defvar gnus-tmp-level)
(defvar gnus-tmp-lines)
+(defvar gnus-tmp-name)
(defvar gnus-tmp-number)
(defvar gnus-tmp-opening-bracket)
(defvar gnus-tmp-process)
--
Bastien
next prev parent reply other threads:[~2019-05-18 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190515175318.10237.53148@vcs0.savannah.gnu.org>
[not found] ` <20190515175319.ACE4B20537@vcs0.savannah.gnu.org>
2019-05-17 16:06 ` master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding Andy Moreton
2019-05-17 16:45 ` Stefan Monnier
2019-05-17 16:48 ` Stefan Monnier
2019-05-17 18:15 ` Andy Moreton
2019-05-17 18:43 ` Stefan Monnier
2019-05-18 8:10 ` Bastien [this message]
2019-05-18 13:00 ` Stefan Monnier
2019-05-18 14:45 ` Bastien
2019-05-18 13:13 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftpc2nfi.fsf@bzg.fr \
--to=bzg@gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).