From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 66db7b2 1/2: Always include the number of unexpected results here too Date: Fri, 26 Jul 2019 16:25:39 +0100 Message-ID: <87ftms4y30.fsf@tcd.ie> References: <20190726075902.16162.83489@vcs0.savannah.gnu.org> <20190726075904.0A44C20C06@vcs0.savannah.gnu.org> <87sgqs4ye0.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="30713"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 26 17:25:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hr26S-0007kk-ST for ged-emacs-devel@m.gmane.org; Fri, 26 Jul 2019 17:25:52 +0200 Original-Received: from localhost ([::1]:41136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr26R-0001J0-Q6 for ged-emacs-devel@m.gmane.org; Fri, 26 Jul 2019 11:25:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51283) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr26L-0001It-2B for emacs-devel@gnu.org; Fri, 26 Jul 2019 11:25:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr26K-0000lR-36 for emacs-devel@gnu.org; Fri, 26 Jul 2019 11:25:45 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:35209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hr26J-0000hj-Gr for emacs-devel@gnu.org; Fri, 26 Jul 2019 11:25:44 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id y4so54878713wrm.2 for ; Fri, 26 Jul 2019 08:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=djg7KwMlcnRP4whMPbNZBruu7Hm9O91yWqWoylHXHSA=; b=Ty2QpEtU5K3+ClXKFCWkt5e/7T/d1U/vVplWhQGVJCVr4NwchDmSvK96c3v7Ocm6Il 9ejJD8x/CIhCQu+2QegNAxS3FLSMxzC+OgecDg/IfqRcXMcrf7Zn3079SLexP0aihdwW uTcJikBA3S3z5HfEQhBUlPMAmC1sEqUQm27/JXCNfnkK+jUZJubiSGCgCLIszNrnsGLm bLST2GMi68FJHof/Wzh+OuexehrlvxFbi7jk1d0Sfm8qWX1Xlg9x8TK4yl9QV8mKe5lB qcI7zOdvdp3Iiml2kVf7sqf/YZfW+eLQCZ/eHOLc8W+OpgZ760/YDlaSsyiLYziRov4T 6Bxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=djg7KwMlcnRP4whMPbNZBruu7Hm9O91yWqWoylHXHSA=; b=p1GnJl7Dj0R0eVhpm1g+Nfq0vfnrFgjsafN4FtpOyxI7EQd+jfG3yE4hCVM/RexGVI Pw9y6ebeBGoZaLjvta6zr83PFxUe4ciRgCsBcqkM7y4oWBgOytUWNZ7eCveaKGalUryK LE7RyZWIa6QOXX0j2I0LycqicgFgJBPZPAl4Hkt/YTjA85EnCDE3gzV4WOcmn/cgddw7 IlRQ/bkp5jm71m+GfC42FQIstGBzhjjUFLtiGZwWe7vF9wfjkJDO2ZZYvVyNUTa6i5uz 7t1LaJr5WyXQEkgsLn+utXf5or9m48T5VRXzzagvE+jWjMQ1gFfIkatxSRt4c2Dj2JGq hNJQ== X-Gm-Message-State: APjAAAV6d+PQ2nyoEdtLcjUWavYSjK/ZoAlNIhQ19G7S4fbqkDbJH9O7 MbRkE3XZuC7aOiWw62vJ9Cyacy8NkKI= X-Google-Smtp-Source: APXvYqzPya4eYEedQTbmTCr8PzxJbUy0uyPM5Du6vukLza1XDtb7v+hNJWh+0uHh13ODovd8aaOzaQ== X-Received: by 2002:a5d:468a:: with SMTP id u10mr46870754wrq.177.1564154741702; Fri, 26 Jul 2019 08:25:41 -0700 (PDT) Original-Received: from localhost ([89.101.223.218]) by smtp.gmail.com with ESMTPSA id 4sm121464226wro.78.2019.07.26.08.25.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 08:25:40 -0700 (PDT) In-Reply-To: <87sgqs4ye0.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Jul 2019 16:19:03 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::429 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238932 Archived-At: "Basil L. Contovounesios" writes: > diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el > index 272fd4aec2..c659e4f3fc 100644 > --- a/lisp/emacs-lisp/ert.el > +++ b/lisp/emacs-lisp/ert.el > @@ -1496,16 +1496,16 @@ ert-summarize-tests-batch-and-exit > (setq ntests (+ ntests (string-to-number (match-string 1)))) > (if (not (re-search-forward "^\\(Aborted: \\)?\ > Ran \\([0-9]+\\) tests, \\([0-9]+\\) results as expected\ > -\\(?:, \\([0-9]+\\) unexpected\\)?\ > +, \\([0-9]+\\) unexpected\ > \\(?:, \\([0-9]+\\) skipped\\)?" nil t)) > (push logfile badtests) > (if (match-string 1) (push logfile badtests)) > (setq nrun (+ nrun (string-to-number (match-string 2))) > nexpected (+ nexpected (string-to-number (match-string 3)))) > - (when (match-string 4) > - (push logfile unexpected) > - (setq nunexpected (+ nunexpected > - (string-to-number (match-string 4))))) > + (let ((n (string-to-number (match-string 4)))) > + (setq nunexpected (+ nunexpected n)) > + (unless (zerop n) > + (push logfile unexpected))) Er, obviously 'nunexpected' can be incremented within the 'unless' as well. -- Basil