From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change Date: Thu, 03 Oct 2019 17:18:51 +0200 Message-ID: <87ftk9svqc.fsf@gnus.org> References: <20191001144135.32717.19241@vcs0.savannah.gnu.org> <20191001144137.1032C20927@vcs0.savannah.gnu.org> <87tv8s32zi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250773"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 03 17:22:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG2vm-00138E-3e for ged-emacs-devel@m.gmane.org; Thu, 03 Oct 2019 17:22:14 +0200 Original-Received: from localhost ([::1]:37520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG2vk-0007qo-TQ for ged-emacs-devel@m.gmane.org; Thu, 03 Oct 2019 11:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44914) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG2sq-0006ZB-4n for emacs-devel@gnu.org; Thu, 03 Oct 2019 11:19:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG2so-000214-C9 for emacs-devel@gnu.org; Thu, 03 Oct 2019 11:19:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:44288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iG2sk-0001rN-Bj for emacs-devel@gnu.org; Thu, 03 Oct 2019 11:19:10 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG2sV-0000Xm-As; Thu, 03 Oct 2019 17:18:53 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 01 Oct 2019 17:30:38 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240518 Archived-At: Stefan Monnier writes: >> I'm not quite sure I followed the last bit -- if something transitively >> required cl-lib, then there's no point for the "top" file to require >> cl-lib, surely? Or is this a style issue. > > If a file (transitively) required by bytecomp.el requires cl-lib, > then when compiling *another* file any missing (require 'cl-lib) in that > other file won't be noticed. Oh, this is just special for bytecomp.el; I get it. >> (defvar emacs-lisp-compilation-mode-map >> (let ((map (make-sparse-keymap))) >> (set-keymap-parent map compilation-minor-mode-map) >> (define-key map "g" 'emacs-lisp-compilation-recompile) >> map)) > > Do we need this set-keymap-parent? define-derived-mode should do it for > us (when the mode is called). I didn't know that. I've now made the change (and reverted the `require'), and this do indeed work as they should. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no