From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Allow hiding stashes from vc-dir Date: Fri, 18 Oct 2019 05:14:27 +0200 Message-ID: <87ftjqlp7w.fsf@gnus.org> References: <831rvegnub.fsf@gnu.org> <871rvex9ue.fsf@mail.linkov.net> <87eezdpjh4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190650"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juri Linkov , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 18 05:15:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLIjj-000nRK-1Y for ged-emacs-devel@m.gmane.org; Fri, 18 Oct 2019 05:15:31 +0200 Original-Received: from localhost ([::1]:34916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLIjh-0005K0-KA for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 23:15:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60610) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLIio-0005JO-HS for emacs-devel@gnu.org; Thu, 17 Oct 2019 23:14:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLIin-0005a9-Dj for emacs-devel@gnu.org; Thu, 17 Oct 2019 23:14:34 -0400 Original-Received: from [80.91.231.51] (port=37012 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLIin-0005Za-7A; Thu, 17 Oct 2019 23:14:33 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLIih-000052-LC; Fri, 18 Oct 2019 05:14:29 +0200 In-Reply-To: (Robert Pluim's message of "Thu, 17 Oct 2019 18:26:10 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241184 Archived-At: Robert Pluim writes: > Toggling with a configurable limit implemented in attached. I did feel > like I was reinventing the wheel a bit, is there no "create a bunch of > strings/regions and apply properties to them" library? I don't think so? Looks good to me, but one minor comment: > +(declare-function cl-subseq "cl-extra" (seq start &optional end)) This functions is ;;;###autoload in cl-extra.el, so I would have thought that this wouldn't be necessary... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no