From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] battery.el, upower fixes Date: Tue, 04 Feb 2020 21:16:10 +0100 Message-ID: <87ftfq3y7p.fsf@gmx.de> References: <83lfpsoj1v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="127894"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andreas Schwab , Eli Zaretskii , Evgeny Zajcev , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 04 21:19:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iz4fD-000XAK-PS for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Feb 2020 21:19:15 +0100 Original-Received: from localhost ([::1]:37404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz4fC-0000dE-Lq for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Feb 2020 15:19:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz4cV-0008Tb-Vw for emacs-devel@gnu.org; Tue, 04 Feb 2020 15:16:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz4cQ-0001aE-9B for emacs-devel@gnu.org; Tue, 04 Feb 2020 15:16:27 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:39487) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz4cP-0001G1-Sw; Tue, 04 Feb 2020 15:16:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580847371; bh=8k2Cu5JLB466C5ebEsxpl7pixgPGhk/20uQfeAqUEAw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RF7vOs3AFQU55YEaT1AhoYSAgfrpVE4Jn7L/9uxgnGGVdZfXmi6Yh+TfkTgNX9l53 F5utOJ5JXRrBWFkomDh5MMmhILXhcJko2G5XqPWMcL1iTOwwLdGVbmAbYj8f8zPx0N MA+Pn6Otz5PTxdha4oQi7CL4yZSOIWYw7SYB8ynw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([79.140.118.126]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MlNtF-1jO0Ri1xFd-00lkdB; Tue, 04 Feb 2020 21:16:11 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 04 Feb 2020 14:55:01 -0500") X-Provags-ID: V03:K1:gbNInmvpB6CmRbLbjDCqiavrDmoXtq9P3LIujVuhCx/ERHoy6Rz lqfTpSGARNVXa1k+rTjARKAN7jAsHjEwnFwSHLqKneEwycsGzhfhmQDvok1SSAMH+QqE6JL SrwFYtEdyQ5UtmjWeee9NJeBRRxcXEKRo0s2FPPJgIHAPvy2ANdKxIwgvIYNGhiEj+DjwU1 GPWy9Ov9cufI+rzI5mA1A== X-UI-Out-Filterresults: notjunk:1;V03:K0:q9cwRJh+O6U=:Pel+1F4CTazaLjeIXHWj0H 9VgpAHbRJnLIvm+/NwDrVPVtiHd7GZiJnj0fikAuNz+jaOUEuwxX1iDeXGYEnIy57y+5LDnZv jS0xTKi+edkuutW0+dlhKy2k6+R8ZrxQ6c6qOX9XE+mDVY7kYp8zhpQ4DHiBZLqhNaxsuX53X 4Vc5jNTtT4kWWivtRmBh8j+gvGjrrDiDNRwEkSWltPFoBB8eoEUHXSVjYfW/9/n95kq4dElPK pRSI627LZu7vF0dYn2B4mR4N3Ezg5k4FEeB3PzMsIxnpjCOghYAlaZ98btA2o9KTB0I8c7+90 j145g3xLK1EgXC9za71JJ2GfbaW5WHwul1oCz+rir56kfv9rfTI2NBABMk0D4vD81LBtRcrev N0eYOcjQA0UcpN3MpvlsodnoJBUfNN2h370rB39JiTi2YiVxEdBTV2iOcqA1ZgoLKwQy0HKHq oFp9K5V13P4/uRSaNnCc6PLn+ZsfVPML4bNR7DyYj4CPkgn8Y3Q2rEFQEBVKv22f5jJkVvn80 j3/xnGh2fl1vAyhfwnT+23xw3M450YsPU5cLiTgOjNxe1hj1j+b+ELDsmCUPm4G5jpKZEbjl6 DBt4XbKYYcY4XG+8qkhp7Wqno7UresSVVqgAkmtEJFoeWOpM3e6BMCgI5JeWQd6IZpBQ4RAb/ mL8GB1yiEDrHjIi1EurNPHSBL/TdrPXuGWdylHsWFS6Jjpgf0SGF/JizD53mKA2SrjM5oO1Xc 8vPPSVI2scnXRtMmNQX5v5fnxFEtO7GfjDDO1jZigrmj9oGpzk0Ngh11lLztQCv9Mae77YNS X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244846 Archived-At: Stefan Monnier writes: >> +(defcustom battery-upower-device >> + (dbus-ignore-errors >> + (battery-upower-device-autodetect :battery)) > > I think there's a possibility that the set of devices changes over time > (e.g. on my machine (battery-upower-device-list) currently only shows > battery_BAT0, but I can insert a second battery and I'd expect the list > to then include a battery_BAT1 as well). So maybe we should instead > allow a special value (e.g. nil) to mean "autodetect" and then do the > autodetection dynamically. WDYT? Usually, D-Bus services send a signal when a device is added/removed. IIUC https://upower.freedesktop.org/docs/UPower.html, org.freedesktop.UPower.DeviceAdded and org.freedesktop.UPower.DeviceRemoved serve for that purpose. So you shall subscribe to those signals and handle them accordingly. > Stefan Best regards, Michael.