From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Tue, 17 Nov 2020 22:02:57 +0200 Organization: LINKOV.NET Message-ID: <87ft57wy32.fsf@mail.linkov.net> References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> <20201116033719.63dryvqm4ozfer2r@Ergus> <92f3cbd7-29a0-461a-a023-562bc6020ea8@default> <87v9e5herj.fsf@mail.linkov.net> <20201116102729.ywubtda6cqdzc45z@Ergus> <877dql59v0.fsf@mail.linkov.net> <20201117004653.thnefjkbj73ao4yk@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , Drew Adams , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 17 21:06:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kf7FX-0002CG-GX for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Nov 2020 21:06:47 +0100 Original-Received: from localhost ([::1]:45066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf7FW-0004Z3-JX for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Nov 2020 15:06:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf7En-00048R-CW for emacs-devel@gnu.org; Tue, 17 Nov 2020 15:06:01 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38361) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf7Ek-0000nN-Ue for emacs-devel@gnu.org; Tue, 17 Nov 2020 15:06:01 -0500 X-Originating-IP: 91.129.97.46 Original-Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 0F307FF804; Tue, 17 Nov 2020 20:05:52 +0000 (UTC) In-Reply-To: <20201117004653.thnefjkbj73ao4yk@Ergus> (Ergus's message of "Tue, 17 Nov 2020 01:46:53 +0100") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 13:32:48 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259310 Archived-At: > Basically we only need to add the command you propose like > > (defun ... > (with-minibuffer-scroll-window scroll-up-command)) > > And bind them... probably with a remap in > completions-highlight-minibuffer-map. Yes, one command could do it all, for example: #+begin_src emacs-lisp (defun with-completions-selected-window () (interactive) (with-selected-window (get-buffer-window "*Completions*" 0) (when-let ((command (lookup-key (current-active-maps) (this-single-command-keys)))) (call-interactively command)))) (dolist (key '(up down left right next prior)) (define-key minibuffer-local-map `[(,key)] 'with-completions-selected-window)) #+end_src It redirects all navigation keys from the minibuffer to the *Completions* buffer where they are bound to cursor motion commands. Then it just needs to highlight the completion under point. Have you tried using 'cursor-sensor-functions' to detect when point is on a completion to highlight it? It seems it could be possible to set 'cursor-sensor-functions' to something like this: #+begin_src emacs-lisp (lambda (_w _x dir) ;; highlight only in non-selected windows (unless (eq (get-buffer-window) (selected-window)) (when (eq dir 'entered) (display--update-for-mouse-movement (line-number-at-pos) (current-column))))) #+end_src to highlight the completion under point as if the mouse pointer hovered over it. This could be useful not only for this feature, but also for tmm-menubar, to make it look more like a menu.