From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 388a874 2/4: Do interactive mode tagging for man.el Date: Sat, 20 Feb 2021 13:26:03 +0100 Message-ID: <87ft1rq61w.fsf@gnus.org> References: <8335xs2grn.fsf@gnu.org> <83h7m71936.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25946"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 20 13:27:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDRLr-0006d2-7f for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 13:27:11 +0100 Original-Received: from localhost ([::1]:59542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDRLq-0003LT-9C for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 07:27:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDRKw-0002tP-RF for emacs-devel@gnu.org; Sat, 20 Feb 2021 07:26:14 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:60372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDRKu-0007R9-8V; Sat, 20 Feb 2021 07:26:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9qgDE06e9sjjAGwBP0uRnyJPb4r2g0xS0Ns/EgDhwk0=; b=XgjzNsx7bnOBQsNgh+FPtXF6vf taLM1zeZyVlD058gOYvdm5iilr1Y1nJrKPGoojk3SYn6NIifIvEMV5oL4uEqyC/VXUcZTKFNVjyll 8Ar3hr/EN1B9EFEtafM6/M61IfQHiZONOb9GlBf91K3OpUMXcXQtgjp8nfL+R7CWxbKg=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDRKn-0005TN-2a; Sat, 20 Feb 2021 13:26:09 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUxFRZQKiNuSz6Z clz///8Ql7uQAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCFAwVKsryZZ8AAAGlSURBVDjLdVOJESMx CDNJA8A2EKCBC+6/txN+dryTO5KJM5YRWMitVYgwt98gAyAyj6wDY+ldKtQ/3IhpA+SfwHaTVwef MuunMitBo6dH1yt7RO+Z4ROoSHwBjL/AqYB0bGdevV3xzTrh3lBJs5F+hfhCadvFkRF/2miK3717 R9+j1dk8iRVyOdZ1D1nLjMb0b2Cik+QHaIckqDGilNlaLuVkQC63yrRrFKBozdtvce8uHJvrLu52 ZRirPwcmmhIZclRfgLtAcFW9J7l6cDW1MFVZIq5fdwdwIa9EfGS4RWYxPi5IoorZJvi2KJsq0y/L SNnyTuBlnv6uCXtaexY3jSgvuPMDAHWIRaAFO9VlMnPyF4b+dTtEJO8Gi6p9S+KDCkU032kEJ84i tO8DqaQbfGrDugdAPdFwt+c8qNwucBUZywPgPfOnJOi3pu7DkKe6yz9uP8C0gxWw/bN8N57gGJfr OXWMFLvXAOwE8A6wI3hKqjZoaNmX+YUJzQe0C/N9EZ1NDd/Wi19c+IDJK2+0ez8hnlRMy+l0qLZ1 OG/yMOz/gMHxF/eRPGVO6/hUAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAyLTIwVDEyOjIxOjQy KzAwOjAw4hQNFQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMi0yMFQxMjoyMTo0MiswMDowMJNJ takAAAAASUVORK5CYII= X-Now-Playing: Fairport Convention's _Come All Ye (2)_: "Quiet Joys Of Brotherhood (Take 1-Edit)" In-Reply-To: <83h7m71936.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Feb 2021 09:39:41 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265301 Archived-At: Eli Zaretskii writes: > So I think the procedure for tagging should include a mandatory > grepping of all the Lisp files to see if the mode or its features are > referenced or used anywhere else. Yup. > There's a 3rd option: > > 3) Put a 'completion-predicate' property on the relevant woman.el > commands, so that command-completion-default-include-p does TRT > with them even though the modes don't match. But the problem here is that these aren't woman.el commands -- they are man.el commands, but used by woman.el? > Because whatever we decide to do now, and the considerations to go > into that decision, will be most probably taken as the canonical > solution for such situations. Yes, it's good to bump into something like this this early in the tagging process. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no