unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>, emacs-devel@gnu.org
Subject: Re: master 388a874 2/4: Do interactive mode tagging for man.el
Date: Sat, 20 Feb 2021 13:26:03 +0100	[thread overview]
Message-ID: <87ft1rq61w.fsf@gnus.org> (raw)
In-Reply-To: <83h7m71936.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Feb 2021 09:39:41 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> So I think the procedure for tagging should include a mandatory
> grepping of all the Lisp files to see if the mode or its features are
> referenced or used anywhere else.

Yup.

> There's a 3rd option:
>
>  3) Put a 'completion-predicate' property on the relevant woman.el
>     commands, so that command-completion-default-include-p does TRT
>     with them even though the modes don't match.

But the problem here is that these aren't woman.el commands -- they are
man.el commands, but used by woman.el?

> Because whatever we decide to do now, and the considerations to go
> into that decision, will be most probably taken as the canonical
> solution for such situations.

Yes, it's good to bump into something like this this early in the
tagging process.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-02-20 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 15:56 master 388a874 2/4: Do interactive mode tagging for man.el Eli Zaretskii
2021-02-20  2:24 ` Stefan Kangas
2021-02-20  7:39   ` Eli Zaretskii
2021-02-20 12:26     ` Lars Ingebrigtsen [this message]
2021-02-20 12:56       ` Eli Zaretskii
2021-02-20 12:23   ` Lars Ingebrigtsen
2021-02-21 10:37     ` Stefan Kangas
2021-02-21 15:48       ` Lars Ingebrigtsen
2021-02-21 19:18         ` Stefan Kangas
2021-02-21 17:43       ` Eli Zaretskii
2021-02-21 19:03         ` Stefan Kangas
2021-02-22 22:34       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft1rq61w.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).