unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mario Lang <mlang@blind.guru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: ericludlam@gmail.com, emacs-devel@gnu.org
Subject: Re: EIEIO default constructor function
Date: Sun, 04 Apr 2021 04:42:38 +0200	[thread overview]
Message-ID: <87ft06bwip.fsf@blind.guru> (raw)
In-Reply-To: <jwvblavzee7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 03 Apr 2021 09:48:40 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> So my question is, what is the rationale behind *always* creating a
>> wrapper for `make-instance'?
>
> You'll have to ask Eric Ludlam ;-)

I guessed as much :-).  I should probably have put him on CC.

>> Could we perhaps add some sort of
>> class-option to disable the wrapper creation?
>
> We could, yes.  I suggest you `M-x report-emacs-bug` so we don't forget.
> Ideally attach a patch ;-)

If a patch is welcome, I might look into that.

> We may also want to make those constructor functions conditional on
> `eieio-backward-compatibility`.

Oh, that is a good idea.  According to my test, CLOS does not create a wrapper by
default, so hiding that behaviour behind `eieio-backward-compatibility'
seems like what I would want to aim for.

> You might also consider using `cl-defstruct`, which
> doesn't suffer from such problems and is lighter weight.

I was actually trying that at first, but it turned out I need
inheritance based dynamic dispatch.  So I am actually very grateful for eieio
being merged into Emacs proper, `defclass' *is* handy if you need its
power.

-- 
CYa,
  ⡍⠁⠗⠊⠕



  reply	other threads:[~2021-04-04  2:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03  3:50 EIEIO default constructor function Mario Lang
2021-04-03 13:48 ` Stefan Monnier
2021-04-04  2:42   ` Mario Lang [this message]
2021-04-04  3:10     ` Stefan Monnier
2021-04-04  8:39       ` Mario Lang
2021-04-04 14:12         ` Stefan Monnier
2021-04-08  3:37           ` Mario Lang
2021-04-08  4:44             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft06bwip.fsf@blind.guru \
    --to=mlang@blind.guru \
    --cc=emacs-devel@gnu.org \
    --cc=ericludlam@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).