From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Simplification of `affixation-function` Date: Tue, 27 Apr 2021 21:11:59 +0300 Organization: LINKOV.NET Message-ID: <87fszb61hs.fsf@mail.linkov.net> References: <87y2d777r2.fsf@mail.linkov.net> <35e2e508-cd0a-b921-af96-9c12da92faf3@yandex.ru> <126afe1f-8ac5-69fc-f6af-a586bc354d03@daniel-mendler.de> <1e9bb418-9f1a-68ee-14de-e68f30f88b0a@daniel-mendler.de> <50cfaa6f-67c0-117f-41b5-10fefabee0d2@yandex.ru> <8735vbr7w3.fsf@mail.linkov.net> <2fa797e1-6a34-abac-2820-440e5edbc494@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Stefan Monnier , Dmitry Gutov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 20:17:38 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbSHB-0001QG-Jt for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 20:17:37 +0200 Original-Received: from localhost ([::1]:42582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbSHA-0007KN-Kn for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 14:17:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbSEH-0005yO-Jt for emacs-devel@gnu.org; Tue, 27 Apr 2021 14:14:37 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:57547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbSED-0008Fv-KS for emacs-devel@gnu.org; Tue, 27 Apr 2021 14:14:37 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 835B7100004; Tue, 27 Apr 2021 18:14:28 +0000 (UTC) In-Reply-To: <2fa797e1-6a34-abac-2820-440e5edbc494@daniel-mendler.de> (Daniel Mendler's message of "Tue, 27 Apr 2021 19:39:34 +0200") Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268544 Archived-At: >> affixation-function was an improvement over annotation-function, >> but nonetheless it has limitations too. What would be a better thing is >> like Daniel proposed a new meta `group-function`, I'd imagine a similar >> meta `format-function` that could receive a candidate and return >> a string to insert to the completions buffer. > > There has been some confusion regarding this already. Some people (me > included) had assumed at some point that the affixation function is > allowed to transform the candidate, since the candidate is part of the > returned list elements (Now I know that this is not the case, but the > function should be allowed to add faces). It should be possible to relax > the affixation function to allow a candidate transformation, then we > avoid the addition of another format-function function. One may ask - affixation-function is called immediately after sorting candidates. format-function could be called immediately before inserting candidates only when they are displayed. > why not change the affixation function then such that it only returns a > single string? We could do that but I think it is valuable to separate > prefix/candidate/suffix for display in a tablist. Because completion--insert-strings needs to highlight the untransformed candidate with mouse-face=highlight. >> The same `format-function` could be used to remove the group prefix >> when `group-function` is in use, instead of providing an additional >> argument `transform` for `group-function`. > > The group function candidate transformation is also to be distinguished > from a potential transformation performed by a > format/affixation-function, since the group transformation should be > only applied when grouping is active. It is therefore better to keep the > transformations separate. API would be more clear when transformation is separated from grouping. So if there is no need to transform group candidates, only group-function is provided. When group candidates need transformation, then additionally format/affixation-function can be provided as well.