From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7) Date: Thu, 20 May 2021 20:53:51 +0300 Organization: LINKOV.NET Message-ID: <87fsyhb8b4.fsf@mail.linkov.net> References: <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <87r1ifpyuc.fsf@mail.linkov.net> <83eeef7nzh.fsf@gnu.org> <87eeed2l0q.fsf@mail.linkov.net> <83o8dh3ybw.fsf@gnu.org> <854d8dbc-b64c-77e1-843b-95ac19e230e2@daniel-mendler.de> <83h7j93wjg.fsf@gnu.org> <83a6p13uux.fsf@gnu.org> <83fsyq2ab4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , emacs-devel@gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 20 20:05:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljn3A-0004eU-TM for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 20:05:36 +0200 Original-Received: from localhost ([::1]:40794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljn39-00076d-QI for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 14:05:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljmsg-0006qW-Oi for emacs-devel@gnu.org; Thu, 20 May 2021 13:54:46 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:47657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljmsd-0007OH-GR; Thu, 20 May 2021 13:54:46 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7A56F200004; Thu, 20 May 2021 17:54:34 +0000 (UTC) In-Reply-To: (Daniel Mendler's message of "Thu, 20 May 2021 11:39:41 +0200") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269507 Archived-At: >>>> I attached the updated patches, the variable `completions-group-sort` >>>> allows the more user friendly values nil and 'alphabetical. I hope it is >>>> more acceptable in this form. >>> >>> Thanks, this addresses my concerns. >>> >>> (Please proofread the comments, doc strings, and Texinfo changes in >>> the patches to make sure you leave 2 spaces between sentences, per our >>> conventions to use US English.) >> >> Thank you, Eli. I went over the commit messages, comments, Texinfo and >> doc strings and made a few corrections. The revised patches are attached. > > From my side the attached patches are ready. Is there anything else that > should be addressed? Juri, does the `group-function` work as desired for > `ucs-char-names` in the current form? See my last mail "REVISED PATCH > VERSION 7". I tried out again, and everything works without problems. Thank you! Since there are no more objections, it seems the version 7 of your patch is the final version, so I pushed it to master.