From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Tue, 25 May 2021 15:24:44 -0500 Message-ID: <87fsyatvcj.fsf@red-bean.com> References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> <83zgxb67g2.fsf@gnu.org> <87mtt9sqh4.fsf@red-bean.com> <87czu58uso.fsf@gnus.org> <878s4tq8e6.fsf@red-bean.com> <874kfguail.fsf@red-bean.com> <875yzwtkuj.fsf@gmail.com> <87lf8prm2f.fsf@gmail.com> <83eeeg8ez9.fsf@gnu.org> <87h7jboirj.fsf@red-bean.com> <83cztz7nvd.fsf@gnu.org> <87wnrn4bld.fsf@red-bean.com> <83cztfc8vh.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1053"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, orontee@gmail.com, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 22:26:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lldcu-000AXl-Ft for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 22:26:08 +0200 Original-Received: from localhost ([::1]:44396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldct-00065D-Fw for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 16:26:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldbl-0004cp-E8 for emacs-devel@gnu.org; Tue, 25 May 2021 16:24:57 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:42978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldbj-0004vL-75; Tue, 25 May 2021 16:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X9nYS1NoG5z3CzV4FaQzMWBGBIht3j60TPokhBqU9TA=; t=1621974294; x=1623183894; b=TXe4ai/k3P2BIrA//lF6Gmrt13tjtWhKmzMpoG1GKna4VlNWxeFwMedgXL7vOlioXsOdDdKsLe J/zZnwO2loqNfv1ULzGpfkUwU08FJxDcPsQAn5EKWdAr9LenBwW+CpDZ7w/NsUyz0Lgi+gXVioXce EDXLW1LNYdEsAIXzDkz5R7tv+ziq93Fo+8RB82PpU17gf24cjeqU16nIJ0Ezuq4dHcdLKw3QRN3qR jGUIaOrmKZoi0M6k+C1YZ12GRcL+L6eU3EvKWAFo7eK2vTIAyz+xF0FG7iRqtWW6j+uSQBrQW8EPQ CK+Fsre/R2LdneoflXFZhk7jyPE5UdJ7//WeQ==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:56734 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lldbZ-00020d-FI; Tue, 25 May 2021 20:24:45 +0000 In-Reply-To: <83cztfc8vh.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 May 2021 15:09:54 +0300") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269892 Archived-At: --=-=-= Content-Type: text/plain; format=flowed On 25 May 2021, Eli Zaretskii wrote: >> From: Karl Fogel >> Cc: orontee@gmail.com, drew.adams@oracle.com, larsi@gnus.org, >> monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Tue, 25 May 2021 00:38:22 -0500 >> >> >> Thoughts? >> > >> >I'll have thoughts when I see the result ;-) >> >> Heh, fair enough. My inquiry was about the general practice of >> having one function's doc string referring out to another >> function's. > >It depends on what you need to say, thus my response above. > >Given what you wrote, and what bookmark-load does with the prefix >argument, I think it is better to say that explicitly in >bookmark-bmenu-load's doc string, since you only need a single >quite >simple sentence to say that, whereas the doc strong of >bookmark-load >is quite long. Well, now that I've done it, I think your way is an improvement -- although it turned out to be slightly more doc change than I expected. Revised patch attached for review. Best regards, -Karl --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Improve-some-doc-strings-in-bookmark.el.patch >From 5817bd661775f4f9ecb1ab0efc831a36fef44578 Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Tue, 25 May 2021 00:26:57 -0500 Subject: [PATCH] Improve some doc strings in bookmark.el * lisp/bookmark.el (bookmark-bmenu-load): Describe prefix argument behavior. Refer to related functions for more information. (bookmark-bmenu-save): Likewise refer to related functions. As discussed in this thread: https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00389.html From: Karl Fogel To: Eli Zaretskii Cc: Matthias Meulien, Drew Adams, Lars Ingebrigtsen, Stefan Monnier, Emacs Devel Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Sun, 09 May 2021 13:37:52 -0500 Message-ID: <87h7jboirj.fsf@red-bean.com> --- lisp/bookmark.el | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git lisp/bookmark.el lisp/bookmark.el index 64b467adfa..31e41a9273 100644 --- lisp/bookmark.el +++ lisp/bookmark.el @@ -2054,7 +2054,10 @@ bookmark-bmenu-any-marks (defun bookmark-bmenu-save () "Save the current list into a bookmark file. -With a prefix arg, prompts for a file to save them in." +With a prefix arg, prompts for a file to save them in. + +See also the related behaviors of `bookmark-load' and +`bookmark-bmenu-load'." (interactive nil bookmark-bmenu-mode) (save-excursion (save-window-excursion @@ -2063,7 +2066,19 @@ bookmark-bmenu-save (defun bookmark-bmenu-load () - "Load the bookmark file and rebuild the bookmark menu-buffer." + "Load bookmarks from a file and rebuild the bookmark menu-buffer. +Prompt for a file, with the default choice being the value of +`bookmark-default-file'. + +With a prefix argument, replace the current ambient bookmarks +(i.e., the ones in `bookmark-alist') with the ones from the selected +file and make that file be the new value of `bookmark-default-file'. +In other words, a prefix argument means \"switch over to the bookmark +universe defined in the loaded file\". Without a prefix argument, +just add the loaded bookmarks into the current ambient set. + +See the documentation for `bookmark-load' for more details; see also +the related behaviors of `bookmark-save' and `bookmark-bmenu-save'." (interactive nil bookmark-bmenu-mode) (bookmark-bmenu-ensure-position) (save-excursion -- 2.30.2 --=-=-=--