From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Draw and scribble notes in GNU Emacs Date: Thu, 09 Sep 2021 16:50:53 +0200 Message-ID: <87fsudu7jm.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6932"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Anand Tamariya Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 09 16:52:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOLPM-0001ax-NU for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Sep 2021 16:52:08 +0200 Original-Received: from localhost ([::1]:34446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOLPL-0000pT-BW for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Sep 2021 10:52:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOLOI-00081L-TT for emacs-devel@gnu.org; Thu, 09 Sep 2021 10:51:02 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:33754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOLOG-00016h-9n for emacs-devel@gnu.org; Thu, 09 Sep 2021 10:51:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6M+KOnzV13vp6q1sC1r9wfqsOLq+SmY8WNEOfPEakJg=; b=dm3KRZ2xNyeCfar6ij72MF/U0C qSA8hEQrftSjk2JTGVaCU5N22F6S9t0SFg3grLRqL8sMzP1ezD6Ga75It35y/n/ofo12vn9reGI9N FHU1VjeN43UsktT10+wFOgfxVu0kWWAO32+sdhn1TauvFeJFAh9xZZT2UnoNVxmWEVl0=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOLOA-0008Fo-5N; Thu, 09 Sep 2021 16:50:56 +0200 In-Reply-To: (Anand Tamariya's message of "Thu, 9 Sep 2021 13:24:44 +0530") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274453 Archived-At: Anand Tamariya writes: > Here's a proposal for drawing and scribbling notes in GNU Emacs. > Features: > > * Draw simple shapes and text > * Scribble freehand > * Visual selection using mouse > * Zoom > * Undo/delete selection > * Erase Looks cool -- perhaps something for GNU ELPA? > I have few questions: > - Can this be included in Emacs core? > - I've copied two functions from Lars > (https://github.com/larsmagne/ewp/blob/master/ewp.el ). How should > attribution work in this case? I've been thinking that I should push ewp to GNU ELPA, but I've never taken the time. (It's a package for editing Wordpress blogs.) > (defun svg--append (svg node) > + ;; id is expected to be unique. > (let ((old (and (dom-attr node 'id) > (dom-by-id svg > (concat "\\`" (regexp-quote (dom-attr node 'id)) > "\\'"))))) > (if old > - ;; FIXME: This was (dom-set-attributes old (dom-attributes node)) > - ;; and got changed by commit f7ea7aa11f6211b5142bbcfc41c580d75485ca56 > - ;; without any explanation. > - (setcdr (car old) (cdr node)) > - (dom-append-child svg node))) > + ;; Remove old node. New node might be a different type. > + (mapc (lambda (a) > + (dom-remove-node svg a)) > + old)) > + (dom-append-child svg node)) Hm... I think this is basically correct, but it's a behaviour change -- previously svg--append wouldn't append if the ID already existed, but would keep the save place in the structure, but with this change, it really always appends. So I don't think that's quite right -- the old behaviour was OK, I think (but undocumented). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no