From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] new package: sndio.el Date: Sun, 14 Nov 2021 18:46:44 +0000 Message-ID: <87fsrypobv.fsf@posteo.net> References: <87tugfw1yg.fsf@omarpolo.com> <87bl2meh4h.fsf@posteo.net> <87mtm6vb5a.fsf@omarpolo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Omar Polo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 14 19:48:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmKYJ-0000Vu-6b for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 19:48:31 +0100 Original-Received: from localhost ([::1]:35512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmKYH-0003Tn-0o for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 13:48:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmKWh-0002md-O4 for emacs-devel@gnu.org; Sun, 14 Nov 2021 13:46:51 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:59681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmKWe-0002PD-Ur for emacs-devel@gnu.org; Sun, 14 Nov 2021 13:46:51 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 503E8240029 for ; Sun, 14 Nov 2021 19:46:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1636915606; bh=aqK/sQxgdI8U01e0EyYlldnP8+eZTqybGxsbIGZbvdY=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=c4C4agkcA9Pfj+LqpakliL4wD3LWDneqQbdLYADCbgwvIIRXbY+k7KYwrcaJX0HnH 7CIBxqFDCNKaIXqql0CatMK13I9zMaZB7PlAPd00xX5ccz9IO89kQzt8BWV5AEeZjh jU/xTGgPxGzpfvt8UjGUEsSN4/cggyQQzFDhvTxT4M0tzO7J1XSGZQ8FF07L+WxaGq OITQZVw2PdQ4jkB+DQCHlwyloYOcz9JgB0EeWYB+CU4i9CiSajYi6HfadAE5gfnLcg k+NEUFg3GrBqOL8aH6X1OtLBC4iE1GF2moq+kp0mnZ//BWNQOqOeqqr3xT0TgyPd+D uDs+HbeFC4E9g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HshBF23lRz9rxL; Sun, 14 Nov 2021 19:46:45 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87mtm6vb5a.fsf@omarpolo.com> (Omar Polo's message of "Sun, 14 Nov 2021 19:27:55 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279442 Archived-At: Omar Polo writes: > Philip Kaludercic writes: > >> Omar Polo writes: >> >>> Hello, >>> >>> Some time ago to scratch an itch I wrote sndio.el, a package to interact >>> with the OpenBSD' audio daemon sndiod(8). Recently, I've enhanced it a >>> bit and added an hydra-like window for a quick interaction and thought >>> it may be useful to others, so here's the submission. It should work >>> outside of OpenBSD too provided that you're running sndio and have >>> sndioctl(1), but I never tried. >> >> From what I see, if I were to download and run the package on a GNU >> System without sndio, there wouldn't be any clear error message >> indicating what went wrong, just an error message indicating that >> sndioctl has failed, right? (this is just from reading and using faulty >> mental evaluation). If the package is to be added to GNU ELPA, you >> should probably add a explicit error message (perhaps even at compile >> time) to clarify what is missing, and that the package isn't mean to >> work on this system. > > Yes, as things are now if sndio-sndioctl-cmd is not found `sndio-update' > fails with a generic error due to process-file not finding the > executable. > > Would something like this be a viable option? > > --- sndio.el > +++ sndio.el > @@ -67,6 +67,8 @@ > (defun sndio-update () > "Update the current sndio buffer." > (interactive) > + (unless (executable-find sndio-sndioctl-cmd) > + (error "Can't find executable %s" sndio-sndioctl-cmd)) > (when (derived-mode-p 'sndio-mode) > (let ((inhibit-read-only t)) > (erase-buffer) > > (sndio-update is the first function called in both the entrypoints of > the package, so it seems a good place for such a check) This looks like a good place to add the check. I just have two questions: 1. Should an error or a user-error be raised? 2. Should the error message be more explicit, and mention that sndio isn't being used on the current system? >>> There's a small gif on the repo that shows sndio.el in action: >>> >>> https://git.omarpolo.com/sndio.el/about/ >>> >>> I was able to fetch and checkout the source in the elpa repository using >>> the attached diff. >> >> The source looks good, I can add it to GNU ELPA if there are no objections. >> >>> Thanks, >>> >>> Omar Polo >>> >>> diff --git a/elpa-packages b/elpa-packages >>> index efa53e3e40..2e21c9bffb 100644 >>> --- a/elpa-packages >>> +++ b/elpa-packages >>> @@ -438,6 +438,7 @@ >>> ("smalltalk-mode" :url nil) ;; Was "git://git.sv.gnu.org/smalltalk" >>> ("smart-yank" :url nil) >>> ("sml-mode" :url nil) >>> + ("sndio" :url "https://git.omarpolo.com/sndio.el") >>> ("so-long" :core "lisp/so-long.el") >>> ("soap-client" :core ("lisp/net/soap-client.el" "lisp/net/soap-inspect.el")) >>> ("sokoban" :url nil) >>> >>> > -- Philip Kaludercic