From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 101bbd1392: Add support for pinch gestures to the XI2 build
Date: Sun, 26 Dec 2021 18:03:31 +0800 [thread overview]
Message-ID: <87fsqf65u4.fsf@yahoo.com> (raw)
In-Reply-To: <83r19zq0l9.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Dec 2021 09:36:34 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> I have a few comments and issues about this changeset:
> This should explain what is a "pinch" gesture. It isn't self-evident.
> The same goes for the NEWS entries.
Thanks.
>> @var{position} is a mouse
>> +position list (@pxref{Click Events}) detailing the position of the
>> +mouse cursor when the event occured,
> ^^^^^^^^^^^^
> "mouse pointer"
Thanks.
>> @var{dx} is the distance between
>> +the horizontal positions of the fingers since the last event in the
>> +same sequence, @var{dy} is the vertical movement of the fingers since
>> +the last event in the same sequence,
>
> What is the meaning of "the distance ... since last event"? Did you
> mean the _change_ in the distance since the last event? And anyway,
> what does "last event" mean in this context -- this is not explained
> anywhere.
I tried to explain what a sequence is later on, and yes, I meant the
change in distance.
>> @var{scale} is the division of
>> +the current distance between the fingers and the distance at the start
> Not "the division of X and Y", but "the ratio of X to Y".
Thanks.
> And I think this kind of event is too high-level. Usually, pinch
> (a.k.a. "zoom") gestures and rotation gestures are reported
> separately, because they have different semantics and will probably
> have different command bindings. Why should be lump them together?
> Moreover, in the corresponding command you require that the rotation
> angle be zero, something that will be hard on the users, I think.
XInput doesn't yet have support for reporting rotation gestures; the
angle here is only reported as part of a pinch sequence, and pinch
sequence only started when actual pinching occurs.
> The doc string should say something about "pinch", and perhaps point
> to the manual.
Thanks.
>> + (interactive "e")
>> + (let ((window (posn-window (nth 1 event)))
>> + (scale (nth 4 event))
>> + (dx (nth 2 event))
>> + (dy (nth 3 event))
>> + (angle (nth 5 event)))
>> + (with-selected-window window
>> + (when (and (zerop dx)
>> + (zerop dy)
>> + (zerop angle)
>> + (equal scale 1.0))
>> + (setq text-scale--pinch-start-scale
>> + (if text-scale-mode text-scale-mode-amount 0)))
>> + (text-scale-set
>> + (+ text-scale--pinch-start-scale
>> + (round (log scale text-scale-mode-step)))))))
>
> Shouldn't this command ensure it gets a pinch event?
Yes, I'll fix that.
> We could potentially be flooded with input messages, and the question
> is whether the above command should process all the pending events of
> this time at once? If it should, perhaps keyboard.c should fetch all
> the consecutive pinch events and produce a single event out of it, or
> at least produce a structure that supplies all the events as one form
> to the application level?
> At least for text-scale, I think you will have a lot of unpleasant
> flickering if you process each event separately.
I didn't notice that, but it's because we round the result of the
scaling. I will try to fix this, thanks.
However, I think TRT here is not for keyboard.c to "coalesce" these
events: the best approach would probably be to use `read-event' inside
individual user commands with a timeout. That way, the commands
themselves get to decide the granularity of the gestures they receive.
> Finally, as this is a user command, we should start documenting such
> commands in the user manual.
Thanks, where would you prefer to put it?
next prev parent reply other threads:[~2021-12-26 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 7:36 master 101bbd1392: Add support for pinch gestures to the XI2 build Eli Zaretskii
2021-12-26 10:03 ` Po Lu [this message]
2021-12-26 10:31 ` Eli Zaretskii
2021-12-26 10:39 ` Po Lu
2021-12-26 10:48 ` Eli Zaretskii
2021-12-26 11:09 ` Po Lu
2021-12-26 11:28 ` Eli Zaretskii
2021-12-26 11:37 ` Po Lu
2021-12-26 11:44 ` Po Lu
2021-12-26 11:51 ` Eli Zaretskii
2021-12-26 11:53 ` Po Lu
2021-12-26 11:58 ` Eli Zaretskii
2021-12-26 12:12 ` Po Lu
2021-12-26 10:42 ` Eli Zaretskii
2021-12-26 10:51 ` Po Lu
2021-12-26 10:55 ` Eli Zaretskii
2021-12-26 10:58 ` Po Lu
2021-12-26 11:01 ` Eli Zaretskii
2021-12-26 11:26 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsqf65u4.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).