unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sean Whitton <spwhitton@spwhitton.name>
To: Eli Zaretskii <eliz@gnu.org>
Cc: philipk@posteo.net, emacs-devel@gnu.org
Subject: Re: New optional Eshell module: em-elecslash
Date: Sat, 16 Apr 2022 13:04:26 -0700	[thread overview]
Message-ID: <87fsmckd6d.fsf@melete.silentflame.com> (raw)
In-Reply-To: <83ee1wzvki.fsf@gnu.org>

Hello,

On Sat 16 Apr 2022 at 10:18PM +03, Eli Zaretskii wrote:

>> +If the @code{eshell-elecslash} module has been added to
>> +@code{eshell-modules-list}, and @code{default-directory} is remote,
>> +then when you type the first forward slash of an argument to a Lisp
>> +function, the Tramp prefix will be filled in for you.  A second
>> +forward slash can be used to undo the insertion, for when you really
>> +do want to pass a local absolute path, such as when you want to copy a
>> +remote file to the local machine.  And when typing arguments to
>> +external commands, the Tramp prefix is not filled in.  The result is
>> +that you don't have to think about inserting the Tramp prefix and can
>> +just type absolute paths in the same way for both types of command.
>> +The Tramp prefix is additionally filled in when you type @code{~/}.
>
> You use passive tense a lot (here and elsewhere), which in many cases
> makes the text longer, more complicated, and harder to understand.
> Please try rephrasing without using passive tense so much.

I'm happy to try to make it clearer, but in the U.K. we don't have this
idea that the passive voice is worse than the active -- I didn't learn
the distinction until after finishing a humanities degree -- so could
you be more specific, please?

>> +*** New optional Eshell module to help avoid mistakes when supplying
>
> The first line of a NEWS entry is a heading, so it should be a
> complete sentence, to facilitate reading the outlines.

Hmm interesting.  I found continuing sentences from the outline heading
to the next line strange, but noticed that many NEWS entries did it, so
thought it was how outline-mode is meant to be used.

>> +;;;###autoload
>> +(progn
>> +(defgroup eshell-elecslash nil
>> +  "When `default-directory' is remote thanks to Eshell's TRAMP
>
> the first line of a doc string should be a complete sentence, because
> some Help commands only show that single line.
>
>> +(defun eshell-electric-forward-slash ()
>> +  "Electric insertion of TRAMP part of `default-directory' in
>> +remote Eshells.  Added to `post-self-insert-hook' when the
>
> Likewise.

I'll try to come up with something.  This rule can be very difficult to
satisfy given line length restrictions.

-- 
Sean Whitton



  reply	other threads:[~2022-04-16 20:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  2:48 Optional Eshell modules -- to emacs.git or ELPA? Sean Whitton
2022-01-29 11:51 ` Philip Kaludercic
2022-04-16 18:57   ` New optional Eshell module: em-elecslash Sean Whitton
2022-04-16 19:18     ` Eli Zaretskii
2022-04-16 20:04       ` Sean Whitton [this message]
2022-04-16 21:42         ` [External] : " Drew Adams
2022-04-17  6:20         ` Eli Zaretskii
2022-04-17 16:48           ` [External] : " Drew Adams
2022-04-19 16:52           ` Sean Whitton
2022-04-20  0:36             ` Sean Whitton
2022-04-20  6:19               ` Eli Zaretskii
2022-04-20 20:14                 ` Sean Whitton
2022-04-21  6:15                   ` Eli Zaretskii
2022-04-16 21:12       ` Sean Whitton
2022-04-16 22:58     ` Stefan Monnier
2022-04-17  5:02       ` Sean Whitton
2022-04-17  6:24     ` Jim Porter
2022-04-19 15:28       ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsmckd6d.fsf@melete.silentflame.com \
    --to=spwhitton@spwhitton.name \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).