unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master ef0546ffcd 2/3: Fix signature of `seconds-to-time'
       [not found] ` <20220806022310.40D6EC09BFD@vcs2.savannah.gnu.org>
@ 2022-08-06  8:43   ` Stefan Monnier
  2022-08-06  9:03     ` Po Lu
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2022-08-06  8:43 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

>  ;;;###autoload
> -(defalias 'seconds-to-time 'time-convert)
> +(defun seconds-to-time (seconds &rest form)
> +  "Convert SECONDS to a proper time, like `current-time' would.
> +FORM means the same as in `time-convert'."
> +  (time-convert seconds form))

Oh, thanks.  I wonder, tho; shouldn't this just have a `seconds`
argument and no `form`, as was the case until 2018?


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master ef0546ffcd 2/3: Fix signature of `seconds-to-time'
  2022-08-06  8:43   ` master ef0546ffcd 2/3: Fix signature of `seconds-to-time' Stefan Monnier
@ 2022-08-06  9:03     ` Po Lu
  0 siblings, 0 replies; 5+ messages in thread
From: Po Lu @ 2022-08-06  9:03 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  ;;;###autoload
>> -(defalias 'seconds-to-time 'time-convert)
>> +(defun seconds-to-time (seconds &rest form)
>> +  "Convert SECONDS to a proper time, like `current-time' would.
>> +FORM means the same as in `time-convert'."
>> +  (time-convert seconds form))
>
> Oh, thanks.  I wonder, tho; shouldn't this just have a `seconds`
> argument and no `form`, as was the case until 2018?
>
>
>         Stefan

I'm not sure what the right thing to do here is, but feel free to make
such a change should you want to.

Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 32ab6d7105 1/3: Improve XI focus handling
       [not found] ` <20220806022310.27F7AC09BFB@vcs2.savannah.gnu.org>
@ 2022-08-07 14:00   ` Lars Ingebrigtsen
  2022-08-07 14:23     ` Po Lu
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-07 14:00 UTC (permalink / raw)
  To: Po Lu; +Cc: Po Lu via Mailing list for Emacs changes

This (or an adjacent commit) seems to lead to this warning:

xterm.c: In function ‘xi_handle_focus_change’:
xterm.c:12564:25: warning: ‘source’ may be used uninitialized in this function [-Wmaybe-uninitialized]
12564 |       ie.device = source->name;
      |                   ~~~~~~^~~~~~

(This is with an --enable-checking build on Debian/bookworm, if that
makes a difference).




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 32ab6d7105 1/3: Improve XI focus handling
  2022-08-07 14:00   ` master 32ab6d7105 1/3: Improve XI focus handling Lars Ingebrigtsen
@ 2022-08-07 14:23     ` Po Lu
  2022-08-07 15:23       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-08-07 14:23 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Po Lu via Mailing list for Emacs changes

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This (or an adjacent commit) seems to lead to this warning:
>
> xterm.c: In function ‘xi_handle_focus_change’:
> xterm.c:12564:25: warning: ‘source’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 12564 |       ie.device = source->name;
>       |                   ~~~~~~^~~~~~
>
> (This is with an --enable-checking build on Debian/bookworm, if that
> makes a difference).

If new is set, then source has been as well.  So I think this is a false
positive.

Feel free to install a change neutralizing this warning for the time
being.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 32ab6d7105 1/3: Improve XI focus handling
  2022-08-07 14:23     ` Po Lu
@ 2022-08-07 15:23       ` Lars Ingebrigtsen
  0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-07 15:23 UTC (permalink / raw)
  To: Po Lu; +Cc: Po Lu via Mailing list for Emacs changes

Po Lu <luangruo@yahoo.com> writes:

> If new is set, then source has been as well.  So I think this is a false
> positive.
>
> Feel free to install a change neutralizing this warning for the time
> being.

Now done, and I agree that the warning from gcc must be wrong.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-07 15:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <165975258963.23776.2101095728150882604@vcs2.savannah.gnu.org>
     [not found] ` <20220806022310.40D6EC09BFD@vcs2.savannah.gnu.org>
2022-08-06  8:43   ` master ef0546ffcd 2/3: Fix signature of `seconds-to-time' Stefan Monnier
2022-08-06  9:03     ` Po Lu
     [not found] ` <20220806022310.27F7AC09BFB@vcs2.savannah.gnu.org>
2022-08-07 14:00   ` master 32ab6d7105 1/3: Improve XI focus handling Lars Ingebrigtsen
2022-08-07 14:23     ` Po Lu
2022-08-07 15:23       ` Lars Ingebrigtsen

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).