* Re: master c641848bce: Simplify describe-function.
[not found] ` <20220905213036.BEEABC0088A@vcs2.savannah.gnu.org>
@ 2022-09-05 21:45 ` Lars Ingebrigtsen
2022-09-05 21:54 ` Gregory Heytings
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-05 21:45 UTC (permalink / raw)
To: Gregory Heytings; +Cc: emacs-devel
Gregory Heytings <gregory@heytings.org> writes:
> * lisp/help-fns.el (describe-function-1): Do not pass
> 'describe-function-orig-buffer' as argument to...
> (help-fns--key-bindings): but use it directly there instead.
> This simplifies 1d1158397b.
This brings back these test failures:
2 files contained unexpected results:
lisp/help-fns-tests.log
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master c641848bce: Simplify describe-function.
2022-09-05 21:45 ` master c641848bce: Simplify describe-function Lars Ingebrigtsen
@ 2022-09-05 21:54 ` Gregory Heytings
2022-09-05 22:05 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Gregory Heytings @ 2022-09-05 21:54 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>> * lisp/help-fns.el (describe-function-1): Do not pass
>> 'describe-function-orig-buffer' as argument to...
>> (help-fns--key-bindings): but use it directly there instead.
>> This simplifies 1d1158397b.
>
> This brings back these test failures:
>
> 2 files contained unexpected results:
> lisp/help-fns-tests.log
>
Hmm... Not after make bootstrap.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master c641848bce: Simplify describe-function.
2022-09-05 21:54 ` Gregory Heytings
@ 2022-09-05 22:05 ` Lars Ingebrigtsen
2022-09-05 22:17 ` Gregory Heytings
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-05 22:05 UTC (permalink / raw)
To: Gregory Heytings; +Cc: emacs-devel
Gregory Heytings <gregory@heytings.org> writes:
> Hmm... Not after make bootstrap.
Still fails after a bootstrap.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master c641848bce: Simplify describe-function.
2022-09-05 22:05 ` Lars Ingebrigtsen
@ 2022-09-05 22:17 ` Gregory Heytings
2022-09-05 22:19 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Gregory Heytings @ 2022-09-05 22:17 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>> Hmm... Not after make bootstrap.
>
> Still fails after a bootstrap.
>
Gosh, indeed! Should be fixed now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master c641848bce: Simplify describe-function.
2022-09-05 22:17 ` Gregory Heytings
@ 2022-09-05 22:19 ` Lars Ingebrigtsen
0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-05 22:19 UTC (permalink / raw)
To: Gregory Heytings; +Cc: emacs-devel
Gregory Heytings <gregory@heytings.org> writes:
> Gosh, indeed! Should be fixed now.
Yup; thanks. With that the test suite is finally green again (because I
disabled the cl-lib test until somebody determines what the semantics
should be 😐).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-05 22:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166241343600.32211.5154227446034857044@vcs2.savannah.gnu.org>
[not found] ` <20220905213036.BEEABC0088A@vcs2.savannah.gnu.org>
2022-09-05 21:45 ` master c641848bce: Simplify describe-function Lars Ingebrigtsen
2022-09-05 21:54 ` Gregory Heytings
2022-09-05 22:05 ` Lars Ingebrigtsen
2022-09-05 22:17 ` Gregory Heytings
2022-09-05 22:19 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).