From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Tue, 18 Oct 2022 20:43:01 +0000 Message-ID: <87fsfkhnhm.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 18 23:01:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oktiG-0004xQ-PD for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Oct 2022 23:01:24 +0200 Original-Received: from localhost ([::1]:50556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oktiF-0007uW-Jc for ged-emacs-devel@m.gmane-mx.org; Tue, 18 Oct 2022 17:01:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oktQc-00079q-Ko for emacs-devel@gnu.org; Tue, 18 Oct 2022 16:43:15 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:36235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oktQa-0008T6-2z for emacs-devel@gnu.org; Tue, 18 Oct 2022 16:43:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C692624002A for ; Tue, 18 Oct 2022 22:43:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666125784; bh=GetEcFwDLlFBpP0OLwm54A8YxJ0qdZ3G5TztWJuBSf4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=BVFwa+SjSqB0azVr/DTTj0ZPNKUmvFC1+4zzpzlkwoqU1aLmOmgGtXFlp4qr3O5cQ T/4lPoEQ/ocCw/lYFCRwekbSOYiJ+RmMFDbQ6WZMV1QmGlm1ejwZO1TqEGkbUo1Y8a FTadsq5RiYW84qeT3GOTHgvRUuUg2co4YPBTEU1Q88NVca576sdrGNgzAYuDLXyHkP LfEO+TnNI2yF4VRREEdZ+0UVwTz8SgP4eyAuAPLvGY+pYOh1jjsk2zewtTVsACvlHk FTX1ixFdC65QR7xPwFL3o3OF5ovYkPCKgGnVkRXh0ioOtiCyusIlAuEGbqE1utmtOp lLu0lpnVVJw/A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MsQmR6c7pz6tnd; Tue, 18 Oct 2022 22:43:03 +0200 (CEST) In-Reply-To: <87czaq1i3k.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 17 Oct 2022 19:21:35 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298079 Archived-At: Philip Kaludercic writes: > Stefan Monnier writes: > >>> + ;; Add `package-vc' data >>> + (let ((spec (cdr pkg-spec)) >>> + (ups (list :upstream 'Git nil nil nil))) >>> + (if (null (plist-get spec :url)) >>> + (setf (nth 2 ups) (concat "https://git.savannah.gnu.org/git/" >>> + elpaa--gitrepo) >>> + (nth 3 ups) (plist-get spec :lisp-dir) >>> + (nth 4 ups) (concat elpaa--branch-prefix pkg)) >>> + (setf (nth 2 ups) (plist-get spec :url) >>> + (nth 3 ups) (plist-get spec :lisp-dir) >>> + (nth 4 ups) (plist-get spec :branch))) >>> + (push ups extras)) >> >> I think rather than invent a new format and duplicate that info into >> `archive-contents`, pushing us to worry about its size, I'd prefer to >> just stash a copy of `elpa-packages` alongside `archive-contents`. > > That sounds like a good idea, as long as we are fine with > "elpa-packages" being a public interface that couldn't just be changed > at will. > > I'll try it out and report back. I have pushed a first draft and it appears to work. It doesn't yet handle all attribute (such as :doc), but that should be doable when I find the time. I wanted to add support for elpa-admin.el, and it will boil down to something like this: (with-temp-buffer (let ((filename (expand-file-name "elpa-packages" dir)) (standard-output (current-buffer))) ;; Remove and compress the contents of the "elpa-pacakges" (prin1 (elpaa--get-specs)) (write-region nil nil filename))) but I am uncertain where to add it, so that it only runs when necessary. Do you have any ideas?