From: Po Lu <luangruo@yahoo.com>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Menu bar items structure
Date: Thu, 17 Nov 2022 19:17:54 +0800 [thread overview]
Message-ID: <87fsehg78d.fsf@yahoo.com> (raw)
In-Reply-To: <87k03tg7ch.fsf@yahoo.com> (Po Lu's message of "Thu, 17 Nov 2022 19:15:26 +0800")
Po Lu <luangruo@yahoo.com> writes:
> Yes. But at the same time, I think we might as well fix the code to
> stop assuming that each character in the menu bar item string
> corresponds to a single glyph, so the changes that have to be done are
> actually much more subtle.
Scratch the last part. I think that problem is already solved by this
piece of display_menu_bar:
/* Remember where item was displayed. */
ASET (items, i + 3, make_fixnum (it.hpos));
/* Display the item, pad with one space. */
if (it.current_x < it.last_visible_x)
display_string (NULL, string, Qnil, 0, 0, &it,
SCHARS (string) + 1, 0, 0, STRING_MULTIBYTE (string));
next prev parent reply other threads:[~2022-11-17 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 17:30 Menu bar items structure Manuel Giraud
2022-11-17 7:49 ` Eli Zaretskii
2022-11-17 8:42 ` Po Lu
2022-11-17 9:57 ` Manuel Giraud
2022-11-17 10:06 ` Po Lu
2022-11-17 10:09 ` Manuel Giraud
2022-11-17 11:15 ` Po Lu
2022-11-17 11:17 ` Po Lu [this message]
2022-11-17 11:16 ` Eli Zaretskii
2022-11-17 15:06 ` Manuel Giraud
2022-11-17 17:01 ` Eli Zaretskii
2022-11-18 7:48 ` Manuel Giraud
2022-11-17 9:23 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsehg78d.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).