From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 10:05:24 -0800 Message-ID: <87fsdbs1zv.fsf@ericabrahamsen.net> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> <87k02ns2sg.fsf@ericabrahamsen.net> <83tu1rcm2m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: fweimer@redhat.com, larsi@gnus.org, emacs-devel@gnu.org, ding@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 19:06:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KWa-0007sS-CF for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 19:06:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7KWF-0001p0-Kx; Mon, 19 Dec 2022 13:05:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KW1-0001lt-Sf for emacs-devel@gnu.org; Mon, 19 Dec 2022 13:05:37 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KW0-0004fO-2y; Mon, 19 Dec 2022 13:05:29 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id C4538FA011; Mon, 19 Dec 2022 18:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1671473126; bh=ItUqjEjbqzG4pb+r3vCqPxwtTkw/GCQqc6nXyC6V7oY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lbjXw43vf52HB3UAN/pQKTBzMVu1oqqHxx95CaiWrIYkkzgHhQCQreYPM5jztkNKd P5SwBPb1VKj4rXEiezMErGdyu1kJuMOoIgo4onanRl4JnyHIhECEgbDjRzQP0EWNsE 4i6jK/+0HKn5IUlEmKSFsnPFKkZoVMN/x2VwVoj8= In-Reply-To: <83tu1rcm2m.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 19:58:25 +0200") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301667 gmane.emacs.gnus.general:91041 Archived-At: Eli Zaretskii writes: >> From: Eric Abrahamsen >> Cc: Florian Weimer , larsi@gnus.org, >> emacs-devel@gnu.org, ding@gnus.org >> Date: Mon, 19 Dec 2022 09:48:15 -0800 >>=20 >> On 12/19/22 19:07 PM, Eli Zaretskii wrote: >> >> Going back to older mail, I see that previously the From: header was >> >> written in encoded form to .overview (slightly wrapped to avoid SMTP >> >> issues): >> >>=20 >> >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' >> >> 'hello3.spec.' -> 'hello3.spec' >> >> =3D?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?= =3D >> >> Thu, 24 Nov 2022 16:27:56 +0800 >> >> >> >> <20220920084307.1696-1-luoyonggang@gmail.com> >> >> <20220920084307.1696-2-luoyonggang@gmail.com> >> >> >> >> >> >> <20221019194930.GC24703@redhat.com> >> >> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> >> >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> >> >> 705 32 Xref: oldenburg.str.redhat.com >> >> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler" >> >> , elfutils-devel@sourceware.org To: Mark Wielaard >> >> >> >>=20 >> >> Now it uses unencoded form: >> >>=20 >> >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows =E7= =BD=97 >> >> =E5=8B=87=E5=88=9A(Yonggang Luo) via Elfutils-devel >> >> Mon, 19 Dec 2022 20:32:48 +0800 >> >> >> >> <20221217165213.152-1-luoyonggang@gmail.com> >> >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: >> >> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To: >> >> elfutils-devel@sourceware.org >> > >> > Is that a problem? I think this was part of the reason for that >> > change in nnml.el. >>=20 >> It would definitely be a problem to change the on-disk representation of >> data in the .overview files! Lots of code depends on a very specific >> format for those files; I've broken things badly in the past by removing >> header encoding there. > > But this change is there since Emacs 28, so if it's a problem, someone > would have hollered already, no? > > Or are you saying that the changes I installed are causing the > difference? If so, I don't see how that could happen, since the > change just ignores any errors signaled by rfc2047, and if rfc2047 > does signal an error, what is stored in the file is the same string as > what we did before the new function nnml--encode-headers was added and > we started using it. > > So unless I'm missing something, the changes I installed cannot cause > any new problems we didn't have since quite long ago. Sorry, I misunderstood -- I thought this change was introducing a difference in the saved files. My mistake for not following along closely enough. Maybe all this warrants some regression tests in ./test/lisp/mail?