From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: feature/android b91e8ada70e 3/5: Fix auto-revert-mode on Android Date: Sat, 25 Feb 2023 11:49:44 +0100 Message-ID: <87fsauvx2v.fsf@gmx.de> References: <167724502313.15669.16640007729364817665@vcs2.savannah.gnu.org> <20230224132344.40927C1391F@vcs2.savannah.gnu.org> <87k006vy4g.fsf@gmx.de> <87lekm2fjc.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35658"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 25 11:50:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVs86-000970-0N for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Feb 2023 11:50:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVs7m-0000Ln-QI; Sat, 25 Feb 2023 05:49:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVs7l-0000LW-AK for emacs-devel@gnu.org; Sat, 25 Feb 2023 05:49:53 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVs7j-0001gv-LZ for emacs-devel@gnu.org; Sat, 25 Feb 2023 05:49:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1677322185; i=michael.albinus@gmx.de; bh=kUWB/4tMLnxTvvzOo501HJA5xv5e8GagNXPblesFYBg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=P7g0TqrOT5De06uPK+KmTFD10L4M4C2PoHF+ooyr4AiklZael5uloMHKSKS2P1yDm kDJskrrjTuUbRUTzYVtBHhxqnqHqdiCon2sigMafOECUY2wmG60CIBI6UH0LK40CJI Dnn8RvyA5O6C1EQuMy6+l3IeGl6zOPbRbQd/vj/ggIvdKW64pm8swZCTo1i0ADt923 lVu5N7WFvJXa+W5fvp1DOKTy7MHq/EdAHVDr7FeMutztOhxFvcKfAAbmHr8kTp+EWL ND9Pk30FRQY8z3vugbKfUgvBHoSRAj+1Ve5Wq9i+J7+UKQBnjEj+SLf1JZoMCOugaw 4r/9K6h0iy03g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwQXN-1ofgi53h0n-00sN7G; Sat, 25 Feb 2023 11:49:44 +0100 In-Reply-To: <87lekm2fjc.fsf@yahoo.com> (Po Lu's message of "Sat, 25 Feb 2023 18:41:27 +0800") X-Provags-ID: V03:K1:E8qTva/yprbj5hThZV1dQYnSYLhl2efkSPHbuATHdvJ+w8Vfs54 k4JYEYUcIrG50KwD2by3aDk2O9hOVgMQ6B9WyFvXAFmtWOlSPJ5td9PdNEBjKFIzeD3e6P2 oR8q1Su6zTYfaPVWD1k21rUYVxYTCSkQWAcC+QT0nx2ZoAPiYFZ4vHG6E8wjeV1pRW+JkCO Ur46O3FGuJC70y0qU88nw== UI-OutboundReport: notjunk:1;M01:P0:Pv/43V7+PhE=;H7Vd3luR6qiCZX+HGWOWRiUVy+1 wo+Mx41DZpguS4SykyqdHwC/Yce9SvzAmhHwjfqsucEyMsIg12e/40aWA+H0J651hGskNKoHd mxSSo/rlQN2k+puG8+TVMLum0/LrCrPUtIBnk9oiJdGHEMW6ZkZvGjRPomQdx5WzF9aRnSAIf A4hbCyngkB5L5QD1Ha64AdtpcZWgRv+aFW8qnRNpgyDxtDSjHtI4BZQ1eeDF3TheqCW7ysmcc 0GLlEfeqnUH1sM06z5l71siUUxQvu9FvgAzh5eN06O3x8SVgzoKKSLMsqkGg+9h0BcL0V3F5r uihfv+2KDPGbptJD0p1p8p+Q3K3o4EHYKyggScn+KwNmH5QD+QoCIKzgbkFBzb+tnpY0NszYZ Z7cfA5ppAzrwGSIjZ8ffS1VSAx9yQtENBNW93QdBGrqqIpDZEKGbqC5RwpBomi/GzOBahJ5rX AacHtL6wZj3dg1i+X+wZp4ZGxSFmnL7KHxnVFIqiMA5RqtRy/BGLAdVzo2FxA2/ULpFcPM+et IRIMME2J7WHbwsxJHREIJ65rYTkCPqeDYaw0tL6mP/8QR2nEP23UPsV//8p6EgS4OfDnpnXbo 6qMqP7T557wIO+Q4/FF7IUr/vtpSM/9ZLEehV07LKCTnP1NBzvrvImRbhAX7l1OqiYGCG7iPO QXZt27AnW9/E9KqmCGylnEDcC1fpOGT8mASRSeSks3EM0zWpWV8fL6uBsRValGmM9WzBI/dT6 UCVhkCcRkqo8cWKjcqwy6OzlDdlpBWEw1rs8jueNHOEvmmeer+cLu5OdxJgLaEdXC1j7nGB4 Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303793 Archived-At: Po Lu writes: Hi, >> I have two problems with this patch. First, nil is not defined as return >> value of *-add-watch functions. If we want to allow this, we must extend >> the interface. >> >> Second, do we really want to have such a hard coded list in inotify.c? >> What about other directories on other systems, like "/proc"? Shouldn't >> we add rather a common interface for excluding directories from being >> watched, say file-notify-excluded-directories (a list of strings)? This >> could be modified on Lisp level, no need to do it in the notification >> backends. > > Shouldn't watching /proc work, in that no error is signalled, unlike > watching /content and /assets, which are wholly inventions of android.c > which do not exist in the VFS? I haven't checked /proc, it was just the first example which came to mind for a directory we might want to exclude. Other examples might be mounted directories, which could also fail for watching files. > Anyway, what return value do you think would be appropriate here? nil might be a correct return value. We haven't simply specified it, and implementing a file-notify-excluded-directories would give the backends a simple way to achive the goal, w/o modifying C source. > Thanks. Best regards, Michael.