unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: Madhu <enometh@meer.net>,  emacs-devel@gnu.org
Subject: Re: tramp "too many open files" [Re: bug#56606
Date: Tue, 21 Mar 2023 10:22:05 +0100	[thread overview]
Message-ID: <87fs9ysblu.fsf@gmx.de> (raw)
In-Reply-To: <87ileuiqph.fsf@posteo.net> (Thierry Volpiatto's message of "Tue,  21 Mar 2023 05:55:44 +0000")

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Thierry Volpiatto <thievol@posteo.net> writes:

> Hello Michael,

Hi Thierry,

>> And also, tramp-archive-file-name-handler checks in case of a file name
>> "/path/to/file.tar/", whether "/path/to/file.tar" is a directory.
>> In this case, tramp-archive also ceases to work.
>
> Yes, the problem we had in Helm was with while-no-input, when a check in
> done under it (file-directory-p or whatever) a dbus event is sent and
> while-no-input fails, we have to let bind while-no-input-ignore-events
> with the new dbus-event added to fix the problem, perhaps tramp-archive
> should take care of this?

Indeed. dbus-event, file-notify and thread-event have been added to
while-no-input-ignore-events in Emacs 29.  What about the following
patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 713 bytes --]

diff --git a/lisp/tramp-gvfs.el b/lisp/tramp-gvfs.el
index 7323374c..0d23f5d8 100644
--- a/lisp/tramp-gvfs.el
+++ b/lisp/tramp-gvfs.el
@@ -872,6 +872,14 @@ arguments to pass to the OPERATION."
    (tramp-register-foreign-file-name-handler
     #'tramp-gvfs-file-name-p #'tramp-gvfs-file-name-handler)))

+;; Event type `dbus-event' is added to `while-no-input-ignore-events'
+;; in Emacs 29.1.  If it is missing, some packages like Helm report
+;; problems.  So we add it here.
+(when (and (featurep 'dbusbind)
+	   (not (memq 'dbus-event while-no-input-ignore-events)))
+  (setq while-no-input-ignore-events
+	(cons 'dbus-event while-no-input-ignore-events)))
+
 \f
 ;; D-Bus helper function.


[-- Attachment #3: Type: text/plain, Size: 35 bytes --]


> Thanks.

Best regards, Michael.

  reply	other threads:[~2023-03-21  9:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <86ilnwafso.fsf@stephe-leake.org>
     [not found] ` <handler.56606.B.165800822832001.ack@debbugs.gnu.org>
     [not found]   ` <86a6989itv.fsf@stephe-leake.org>
     [not found]     ` <8335f0qbvn.fsf@gnu.org>
     [not found]       ` <831qujrjnm.fsf@gnu.org>
     [not found]         ` <86h73ex91m.fsf@stephe-leake.org>
     [not found]           ` <83k089omhb.fsf@gnu.org>
2023-03-20 13:31             ` tramp "too many open files" [Re: bug#56606 Madhu
2023-03-20 14:58               ` Thierry Volpiatto
2023-03-20 15:20                 ` Michael Albinus
2023-03-20 16:57                   ` Thierry Volpiatto
2023-03-20 17:56                     ` Michael Albinus
2023-03-21  5:55                       ` Thierry Volpiatto
2023-03-21  9:22                         ` Michael Albinus [this message]
2023-03-21 13:43                           ` Thierry Volpiatto
2023-03-21 15:17                             ` Michael Albinus
2023-03-21 17:19                               ` Thierry Volpiatto
2023-03-20 15:04               ` Michael Albinus
2023-03-20 18:47                 ` Madhu
2023-03-21  9:30                   ` Michael Albinus
2023-03-25 23:23                     ` {Spam?} " Madhu
2023-03-26 18:56                       ` tramp "too many open files" Michael Albinus
2023-05-14  5:44                         ` Build failure: " Madhu
2023-05-14  7:10                           ` Michael Albinus
2023-05-14 10:00                             ` {Spam?} " Madhu
2023-05-14 11:24                               ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs9ysblu.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=enometh@meer.net \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).