From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Why 'define-package' marked obsolete? Date: Tue, 21 Mar 2023 17:15:49 +0000 Message-ID: <87fs9ynhyy.fsf@posteo.net> References: <83zg87739o.fsf@gnu.org> <87jzzbp6bn.fsf@posteo.net> <87355y78fs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 18:16:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pefbK-0006X3-Kp for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 18:16:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pefad-0004OO-Ao; Tue, 21 Mar 2023 13:16:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pefaZ-0004J5-LD for emacs-devel@gnu.org; Tue, 21 Mar 2023 13:16:00 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pefaX-0003Rp-GK for emacs-devel@gnu.org; Tue, 21 Mar 2023 13:15:59 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E1A1F240730 for ; Tue, 21 Mar 2023 18:15:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679418954; bh=BEX09JfHehPZVXGG/IaVuibIG9cjSZXp16hu7Ldcib4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=YkeEpmHPgqC4BAXsaSmEEaB3kXBSZxXVMQedPe9Deg5cwSz4RVE0M/WakcDI8Gz81 KS1NDcTX8JT+Y61o0hBTQDGxF/3d1smE6KE5NGEmwdEdESPsfX9HpHiRkxVN/ucnly JAk2UCOwhE4YVQdmTPjVOxeBTpViGebBcZmp25zw27CftKm0DTXkW+rN127i5fL4m2 dSxjcq/sPFgxN4sCLqFmPqGxj79MCM5TrBmyAw78kQM6G59hDYlj06itvB4n356JDi 0MqNmzhV1LbYR+IQBIemRweogctw9VLhDBzlplx7Nc+36UI/EvjrUl/b3Wh1g38Sl7 y0Id2znN8ja4w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PgytH6Hbwz9rxY; Tue, 21 Mar 2023 18:15:49 +0100 (CET) In-Reply-To: (dalanicolai@gmail.com's message of "Tue, 21 Mar 2023 18:09:51 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304674 Archived-At: dalanicolai writes: > Thanks for the explanation... > > >> No, the -pkg.el file is generated by ELPA using the information from the >> main file. There is no need to write it yourself, in fact it is a waste >> effort since it will be overwritten anyway. Package-vc does the same >> btw. >> > > I was trying to create a multi-file package, but before submitting it to > elpa-devel, I was testing locally if I did things correctly. So I defined a > 'local archive' in a directory, then uploaded the .tar file to that > directory/archive, and then checked if installing worked. When doing > this, it seemed necessary to create the -pkg.el file manually. The best way to test it would be to check out elpa.git from https://git.savannah.gnu.org/cgit/emacs/elpa.git and follow the manual in there. But unless you did something unusual, I would expect it to work (and if it doesn't, someone here will be able to say why and how to fix it). > Anyway, I understand things better now. > > Thanks again! > > On Tue, 21 Mar 2023 at 10:35, Philip Kaludercic wrote: > >> dalanicolai writes: >> >> > Ah okay, I see. >> > >> > So I assume that this means that as a function 'define-package' was >> > redundant, but we should still include a 'define-package' in the >> > -pkg.el file of a multi file package? >> >> No, the -pkg.el file is generated by ELPA using the information from the >> main file. There is no need to write it yourself, in fact it is a waste >> effort since it will be overwritten anyway. Package-vc does the same >> btw. >> >> > The initial comment of 'package.el' mentions that the -pkg.el file >> > should consist of 'a call to' define-package. I would say this >> > formulation is somewhat confusing/misleading then? >> >> You are right, that comment is outdated and should be revised. >> >> > Or is the -pkg.el file just outdated? And did I miss the news about it? >> >> No, the file is still required because it contains the package >> descriptor. The only thing that changed is that instead of the contents >> being evaluated as code, they are read in and processed manually. >> Without that file, you will notice that `package-load-descriptor' >> wouldn't add the package to `package-alist', which in turn means that >> `package--activate-all' wouldn't activate it. >> >> > On Mon, 20 Mar 2023 at 20:32, Philip Kaludercic >> wrote: >> > >> >> Eli Zaretskii writes: >> >> >> >> >> From: dalanicolai >> >> >> Date: Mon, 20 Mar 2023 17:21:04 +0100 >> >> >> >> >> >> Can I ask why 'define-package' was marked obsolete? >> >> > >> >> > It never did anything useful. Its original implementation just >> >> > signaled an error. >> >> >> >> I just looked up the definition from when package.el was merged[0], and >> it >> >> did stuff, mainly modifying `package-alist'. >> >> >> >> [0] >> >> >> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/package.el?id=44198b6ee97bcb0ac88a5cadd1bf9b62048d0156#n513 >> >> >> >> -- >> >> Philip Kaludercic >> >> >> -- Philip Kaludercic