From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 19:10:02 +0200 Message-ID: <87fs6whaj9.fsf@gmail.com> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> <87sfawhj91.fsf@gmail.com> <83a5x4yci0.fsf@gnu.org> <87o7lkhdwz.fsf@gmail.com> <83352wy6pz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 19:10:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8l4D-0007ym-Dt for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 19:10:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8l3V-0008B6-8C; Mon, 12 Jun 2023 13:10:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8l3R-00089x-N3 for emacs-devel@gnu.org; Mon, 12 Jun 2023 13:10:09 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8l3P-0004YO-Kz; Mon, 12 Jun 2023 13:10:09 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4f60a27c4a2so5173244e87.2; Mon, 12 Jun 2023 10:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686589805; x=1689181805; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=RnOCymPh17rR37ys9twKg2/EaciiWYlmHblkadD/3iQ=; b=T0af8R4VRiZBZ5Xvjc3ArJoboA4Y9EjSrX2edNybqoNdrAgIw4xl4jRHDAI9f6bo0B Jhp0kDHDOLiADRefLZRD+L3eU58cZ1O33l1f6nKskrGpdVQ7upi6TepOa+W5t4kWdPVQ zeY2EkE/F5bdzfnsnKym59+6uTtAHmyReKc/JF69LPtjnrys6sNvUuo6fS06Pia/py3T WJPmeX7sUF/dSt6FYQrvaCyx+yFVPYqUWQ7CARCuz8fCf8zpYC6g5s4cbENlZuo71DkT c8aEdm68/KcUcrO35Or/sduJNXabujJdbmRJEcvZsaDg1K6RtX7Pyxh+8X8AZ2njLCJ2 MCVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686589805; x=1689181805; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RnOCymPh17rR37ys9twKg2/EaciiWYlmHblkadD/3iQ=; b=iFnnrXdvKrgbVv6JD4XTC2tZOwPjTa5rsxaZKDOYgqWnnfoONvzmtZNIroFKpjaNL/ GvMcRiJStcR8gyxB3vV4MYBLb4kpQoJJ8LCCOgcTRjzEgEY4cvprfOagAYz/N4PvYOMD t1lz2P7HiWz/6C5Xr8mmDLvOC7n/erv4neJFJfku0eH3S5An8kARm3kZZYvACMZXGlSC Ou73QbmuVC7Q4wC14kf2+Ul7Te0HvehoLARKVXFGIeb71SBKa9NHqmHBwrm6DTVtfDV5 I4ckxmyt+FwkexRCt+RcHecQyNJoaZ19w4pefpLBFjruYiI6vqrgQ3MtZwmHRRoMXlJz 3X+A== X-Gm-Message-State: AC+VfDz2qATNI+kwz9KTwHS4Lqofw5X1r5xieuH79CwvvP5IzrZA86uO mXgQsNiDb9lmH17AbwJhbQsJ72lxI5U= X-Google-Smtp-Source: ACHHUZ44X0k4tRaBiJA8v48XnN88iqqrRVJNhUJatJm2T1S79h1/a/VbveHlKJibtKSyDY9HvIACrg== X-Received: by 2002:a19:8c0a:0:b0:4f4:dfd4:33e4 with SMTP id o10-20020a198c0a000000b004f4dfd433e4mr3662533lfd.51.1686589804297; Mon, 12 Jun 2023 10:10:04 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 10-20020a05600c24ca00b003f7e4d143cfsm11897270wmu.15.2023.06.12.10.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 10:10:03 -0700 (PDT) In-Reply-To: <83352wy6pz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2023 19:40:24 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=rpluim@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306756 Archived-At: >>>>> On Mon, 12 Jun 2023 19:40:24 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: michael.albinus@gmx.de, emacs-devel@gnu.org >> Date: Mon, 12 Jun 2023 17:57:00 +0200 >>=20 >> The minimal fix would be: >>=20 >> diff --git a/lisp/window.el b/lisp/window.el >> index 78b0787abdb..16f16a75418 100644 >> --- a/lisp/window.el >> +++ b/lisp/window.el >> @@ -8776,7 +8776,7 @@ display-comint-buffer-action >> :group 'windows >> :group 'comint) >>=20 >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previ= ous-window >> +(defcustom display-tex-shell-buffer-action '(display-buffer-in-prev= ious-window) >> "`display-buffer' action for displaying TeX shell buffers." >> :type display-buffer--action-custom-type >> :risky t Eli> Fine by me, please install. Done, although we should consider having that action have '(inhibit-same-window . t)' in it. Maybe on master. >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previ= ous-window >> +(defcustom display-tex-shell-buffer-action display-buffer--in-previ= ous-window-action >> "`display-buffer' action for displaying TeX shell buffers." >> :type display-buffer--action-custom-type >> :risky t Eli> Why do we need an extra variable here? We don=CA=BCt, it just looks nicer than stuffing a multi-line constant in the default value field. Robert --=20