From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] main 2ec80977e1: * elpa-packages (dired-preview): New package Date: Thu, 13 Jul 2023 20:29:24 +0000 Message-ID: <87fs5rpnbv.fsf@posteo.net> References: <168884609732.27984.6450580686777461843@vcs2.savannah.gnu.org> <20230708195457.95F1AC11DD8@vcs2.savannah.gnu.org> <87zg43iprw.fsf@posteo.net> <87h6q7zmcy.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1649"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 13 22:30:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK2xA-0000Ew-Ge for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jul 2023 22:30:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK2wP-0001Kt-BW; Thu, 13 Jul 2023 16:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK2wN-0001Ka-GP for emacs-devel@gnu.org; Thu, 13 Jul 2023 16:29:31 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK2wL-0003tB-F3 for emacs-devel@gnu.org; Thu, 13 Jul 2023 16:29:31 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 36F3C240104 for ; Thu, 13 Jul 2023 22:29:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689280166; bh=w28wNb4JqhbZLDlvXrNPwrMAHUjl9P+0n4fa1LGOev0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Bdkx4AAWCN78zlgqju/4kOzGsd53ZfPPhPiB9dT8bnxdJBDzhNOpXIrkFoB5/yGUA gNU1bdvu7OaMRxOgnkWtyJBa7dtFxOE5AmRfzA/Ox52Z6TYof1FNoc2eGZeR4Z5kH5 lJT7i4MQUnd3UNQLv1Gu2vGHMt5/ezuwxZOE4xWGFOMPW21feNLemDGO82EkCHLiWi QKaIChikBCFLg2QPzG7zlWbZvbs8xHudAvikpfxip0KgAeaBfIC2HIsd0hW46dWwYU 6+XyW6pIVhTByUauTPh9PS2tvlhNrPkH7EzlF45SYyMLTRypQqNPl2FQvTad68u5PU pVyN2kDvgbfFg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R25n13brSz6tsb; Thu, 13 Jul 2023 22:29:25 +0200 (CEST) In-Reply-To: <87h6q7zmcy.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Thu, 13 Jul 2023 21:40:13 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307829 Archived-At: Protesilaos Stavrou writes: >> From: Philip Kaludercic >> Date: Mon, 10 Jul 2023 18:29:23 +0000 > >> [... 35 lines elided] > >> diff --git a/dired-preview.el b/dired-preview.el >> index 853131b..b3517bd 100644 >> --- a/dired-preview.el >> +++ b/dired-preview.el > >> [... 206 lines elided] > > Hello again Philip, > > I believe I pushed all the relevant changes you suggested. The only one > I have not done yet is the 'dolist' VS 'mapc' that you and Stefan > commented on. I need to understand the technical differences better, so > as to know when to use 'mapc'. Do you have any concrete questions? Semantically they should be equivalent, it is just a matter of estimating the cost of a funcall and of closures, which is why I suggest replacing (mapc (lambda (x) ... x ...) xs) with (dolist (x xs) ... x ...). > All the best, > Prot