From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Tropin Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon Date: Thu, 27 Jul 2023 12:38:07 +0400 Message-ID: <87fs59rbps.fsf@trop.in> References: <877cqpsnct.fsf@trop.in> <87fs5a6fyj.fsf@trop.in> <87a5vi4lc7.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 27 10:53:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOwkx-0008tH-G6 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jul 2023 10:53:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOwgD-0008Ip-Bk; Thu, 27 Jul 2023 04:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOwXr-0005Se-Dm for emacs-devel@gnu.org; Thu, 27 Jul 2023 04:40:27 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOwXp-00039V-K6; Thu, 27 Jul 2023 04:40:27 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id C48714000C; Thu, 27 Jul 2023 08:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1690447222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1SoeYEtgj0IyvNeo2Wce20IIwQl5A7RGQVX20FS8S8I=; b=fRWFwY1hwNuPowxa5rxXTX7SFQr9VTV6yMwcACmvbzkjonXzxKU+FVkk93/tsZDjJRIrPh inma5t7udJNHhCz66IwKiK+sRzaPK6b8Hv0KTk8UBj0usbP6uOyw67MP+mxU/EPzJ7a7Vk H78op20qKikoIxxYlJ53kpQyjYMF/wJMpRt/Ii8MeKCcHo+1LbYxB3Ohh+8aQfavCPGXhz cks4oNhTjjBZWJEXZlyKW48kNfT17txWTlCWgoCoM184Wm5pQDH9c8N1AJsBDvZhjXdsQO iwLded8CM1AVrPdCkuNUXlyl9knmjpkxcDD6TvVjLtBBfs6ilgru1TT23LqHjw== In-Reply-To: <87a5vi4lc7.fsf@gmx.de> X-GND-Sasl: andrew@trop.in Received-SPF: pass client-ip=217.70.183.194; envelope-from=andrew@trop.in; helo=relay2-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 27 Jul 2023 04:48:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308138 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-07-26 19:46, Michael Albinus wrote: > Andrew Tropin writes: > > Hi Andrew, > > Eli did comment already (I agree with him). Just some few further nits. > >> Icon is not always a file name, but can be just an icon name. >> https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec= -latest.html >> >> diff --git a/doc/lispref/os.texi b/doc/lispref/os.texi >> index 4bcc9d5fea6..efa89fa387c 100644 >> --- a/doc/lispref/os.texi >> +++ b/doc/lispref/os.texi >> @@ -2885,6 +2885,9 @@ Desktop Notifications >> @item :app-icon @var{icon-file} >> The file name of the notification icon. If set to @code{nil}, no icon >> is displayed. The default is @code{notifications-application-icon}. >> +If value is a string @code{expand-file-name} will be applied, if value >> +is a symbol it will be used as is (helpful when using Icon Naming >> +Specification). > > Please add the URL of the spec above, perhaps as @footnote. Furthermore, > icon names are not restricted to the ones from the Icon Naming > Specification, you can use any icon name which is in the user's current i= con > theme. The specification tells you what shall be offered on any system. F= or > example, you could say now > > (notifications-notify :title "The thunderbird icon" :app-icon 'thunderb= ird) > > I have installed thunderbird, of course. And I don't need to care that > the corresponding icon files are installed at /usr/share/icons/**/apps/th= underbird.png > >> diff --git a/etc/NEWS b/etc/NEWS >> index 5883b4df2a7..e1a5cbf0340 100644 >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -548,6 +548,13 @@ Similarly to buffer restoration by Desktop, 'recent= f-mode' checking >> of the accessibility of remote files can now time out if >> 'remote-file-name-access-timeout' is set to a positive number. >> >> +** Notifications >> + >> ++++ >> +*** Allow to use Icon Naming Specification for app-icon. >> +Symbol can be used as a value for :app-icon to provide icon name >> +without specifying a file. > > Say ':app-icon'. > > I found your initial example funny, maybe add it here: > > (notifications-notify > :title "I am playing music" :app-icon 'multimedia-player) > > Best regards, Michael. Addressed points mentioned in both emails and sumbitted v4. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmTCLO8ACgkQIgjSCVjB 3rB85w//cUYE39wYpCU2Yz7kbEAt+h58GTGsTWCgcRibu2lecxkl5MPwjbCHTCum N6eCz6g3cacNG+hxXRLET0c+8Ot+tRDGiMsuJ4gd3577u/giHuQoqmVdQk01RB3F az70FcMgs8OEADOH9r/vrGrwleikM0UoqPsXTbW4ZQJXCL93iiglm+ZwTzbzbE89 +xvuz+aGbkY5hWENESKJ4MeAVFxQaUbJ9iMszh9JwgAttjNqX384ba8R5865M1el xQuwiewwV9qi4Gd2Ig04C2D6C8wIWYwM8qMBOMGtejEI+zbQELNjRxjmz9FMkFKt PqA+u2rBmVoFAWnNYZNMRVM9Ov2hI4sqVkYB6p5o0dC1RSANXzXQ1aANPIerxdmw EsW1Et2dwQYUoqPPZSrSP/KW5Si3/iglrChC5pJBxjWU8JlXQwTykfZyLniOQsqo 9d2suF+Ph0ar1EfM6Ej6kzcMD6cF5nP3fvd5W55SH1jW9UtL7UMSSGWasg/sLbW0 qviP4D0e1jJc43iQuCNwWKldOkiy+CxYOMDKbaMxv78IwhQHL0oCa5wWb7CG72RM 1xuU50L+Aoq3z2qrjHkq+LKc1k5YKOZIbN518j7+v+vLizP0d9ESq48SLVoYfjMN hAdZy7qAGCSWdaMxVBmto6B6zC7GRz8Y0sxR0Dn+GiinUBKUIz8= =QBgV -----END PGP SIGNATURE----- --=-=-=--