From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: lua-ts-mode Date: Thu, 27 Jul 2023 08:34:45 -0500 Message-ID: <87fs59nwef.fsf@pub.pink> References: <87o7jyd3bs.fsf@pub.pink> <831qgunew3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35501"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 27 19:51:25 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qP593-000909-5s for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jul 2023 19:51:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qP4LF-0006Gg-Oz; Thu, 27 Jul 2023 12:59:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qP3zN-0007Ed-L1 for emacs-devel@gnu.org; Thu, 27 Jul 2023 12:37:21 -0400 Original-Received: from out-106.mta1.migadu.com ([2001:41d0:203:375::6a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qP3zL-0003MG-D8 for emacs-devel@gnu.org; Thu, 27 Jul 2023 12:37:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1690475836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yDlxgFA71gFro0KDGI8sRTRLj0PE1/ghnjG05SR968Y=; b=Bg/Z6H3TAn3if60GNMClwbbuFqruAbt4eAE8tBC/Au4RkUdcVJt4Qfo4vfeYW0UVYfBTqL RdMQoWeU9q1o7pz/GW6ZGAxmn0lE5n+jzTAsfucLzZZQPqoBOGq1mBEFXS76YHEidsllhz kYLp6UixphGO0E9HnaQulDrwSqv4Jog= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <831qgunew3.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::6a; envelope-from=jm@pub.pink; helo=out-106.mta1.migadu.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 27 Jul 2023 12:59:53 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308165 Archived-At: Eli Zaretskii writes: >> Date: Wed, 26 Jul 2023 19:42:16 +0200 >> From: Theodor Thornhill >> >> I'll take a look at the code a bit later, but is anything preventing >> us from adding this in-tree? > > My thoughts exactly. Sounds good. I=E2=80=99ll prepare a patch for Emacs. > And another question: does this mode work with the other Lua grammar > library I know about, https://github.com/Azganoth/tree-sitter-lua? It works in the sense of nothing going horribly wrong if you try to use it. You can still edit Lua files but due to differences in the trees and node names the experience is somewhat degraded. > If not, would it be possible to make it work with both? Without having tried more than just swapping out the tree-sitter-lua.so files it looks like it would be possible without much hassle. I don=E2=80=99t think it=E2=80=99s worth any hassle though. The one I used = is the same as used by Neovim[1] and is already packaged for Alpine[2] and NixOS[3] and is in the queue for Debian[4]. I=E2=80=99ll see about getting it added = to GNU Guix (which already has a number of other grammars). Is working with both a prerequisite for inclusion or is there some other reason to support them both? I=E2=80=99m not opposed but it doesn=E2=80=99t= seem like an important thing to do at this time. 1: https://github.com/nvim-treesitter/nvim-treesitter/blob/6aababfca4e3d72c= b1e8fbbdac4115a5f88107d0/lua/nvim-treesitter/parsers.lua#L900 2: https://pkgs.alpinelinux.org/package/edge/community/x86/tree-sitter-lua 3: https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/development/tools= /parsing/tree-sitter/grammars/tree-sitter-lua.json 4: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1034075