From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sun, 28 Jan 2024 09:34:15 +0800 Message-ID: <87fryijl60.fsf@yahoo.com> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> <875xzfkxq7.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org, dev@rjt.dev To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 28 02:35:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTu4w-0006si-Ov for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jan 2024 02:35:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTu4E-0007G9-1D; Sat, 27 Jan 2024 20:34:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTu49-00079z-6Y for emacs-devel@gnu.org; Sat, 27 Jan 2024 20:34:33 -0500 Original-Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTu45-0006aS-J7 for emacs-devel@gnu.org; Sat, 27 Jan 2024 20:34:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706405667; bh=OGyr1xgJA+1Ws2J1sQpkvSIHuxeGeXCk/x/IKQ9YB4A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=b4sUq99p3lG3HGwv15VAuRtNxGfgBmjiWenAniAM5mwyLZBCvUqWiaHvlZUvWj4I70wgscHyeD+rafo9+V2F4cQIA24dxFzzux8iRUbZpwi+iuCrqA5UmqU3uTInHxlNPdIHO6q2KPCjA76+d3M6zyvOI1Ux5prpWKHoZBWqnNd9iVXDe9AAvvSFmIKnd/e41Xm0HjdTTyOBXwS73SQ1OuRaa2FcbS6mjLRotyDRity88MrIFRkNnLPQysFHauROZzR8gjEc1Vy0jMM7403Nha1thLkINqrq76aiLmFOhx7MH7wyf3rufgCB5B8Si5hDmDs8BFHon1FrUJGdsPIElg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706405667; bh=lqdglr7V9RwpKBPxBZjmYadT1aRuHEK5sZyZmopEA8r=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=kxRngbYHNaE2HyJgBVYlgld2dNGabTlQ503YJsYcvzNLBfT7PQxDX+V1dwNwPG/3ZpadmRSQHZ9EevqoKEt6BmwUJeENcP3LLG4wqAEaxHcFOPqVOxdtrBOHNyP7vL9JMyP6okgLym2J3Jxx3y2Thf7g5UyROFtpyAuFYUSIqpoTVp+ly4FUqJ3anSq1QgsyGAjHoOl7XuheuDkgYLlvXncHJIKGHHvN2K/lLqDa7gEqIbGdXuYSXpexsLq7vQhDJk4K4lt6+eyWOZpCBBu6I+AB8rGwKNJAiWZtrcOzbqihjokmGMUyGrWF1+mWcOyYYauRk+79WpQ2ZzL4Ml5bCQ== X-YMail-OSG: OeahuW0VM1mpGdQ89bJfBRlAUs7QhQxb6J88fyDAO4tyK.BdEYplrFj2AjIfyV0 qSfqnmfA3MLqFtuf5_n9mXkPTkujSXu._aOCXAnbBqbm6rblVETitonRN9OvnJPMpdyOCv7xEiwc rDKkr.vtDG7IY2Em5fz0NbVVynUa5Uhdj0mZPtne0l_59jAF49TLeSVCcuaZ_1YDJgr3Ua2_XyWe jTPM0u2HSIPnbStLBv8VYSHI523hlpbgRVLDXSwDBwKy02FtpCY2J0HudKkZ2YG6WZCOdGDqjvo_ ik5v_O6VZ4Wit1msInWTeaX1JEknO5pFRInFKZLfOTAdLChVZU0sr2aJlm2bgah3CV.9cVzjHBy7 G7r3WhLx_KoohU_yGXmefxGk.dCxkpOowh5woxk2yjWQXkLR_LuRxl1OpTgspOpK9NMeoLMAyHqV xiakISjKnsgWGepS0FTriV_Fqtb_cjaKAIl42SiaxR3BRCP__1EjaWxbc3oOTPZwt9qrOh6EndOA Qqxmy7pQgK2AxcZrJbJqAiGwSvv0Ihfj8Wl_IpebhqkmQFZy2zyfzn.v9Ug9hZVn.euR2aLs7UDh VO4Nh.8_Q4D9PlrOsRwJ3bXlczxkHugjBRfdYYl030NP93U4o_gVhMViz3m5FndVtxfekX1wpyz5 KdLUt9C2O6d648K4BHtkxxb8E9KdN2wGO4I9iV7Ghh6dLoBm0Y4zCBDPjPeInASPbeLw4shucjtG ZnKZPxkle6umTp8pvzjf23VHJqma9fV028A7NhAr.rVWr9aDGrSnllRQdSBduYWr3_I0JT0Hp38n hK7ZSdsAxiXYQOUSEAFnJ1Hkly7fobZj15Nu9jYYoY X-Sonic-MF: X-Sonic-ID: 561942b3-d4ad-4f95-b3ad-f48ed3127522 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sun, 28 Jan 2024 01:34:27 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-zp62z (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5d5009ba69580c4a56d48fa64a4cc147; Sun, 28 Jan 2024 01:34:21 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sat, 27 Jan 2024 14:40:02 -0800") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.33; envelope-from=luangruo@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315507 Archived-At: Stefan Kangas writes: > Po Lu writes: > >> Yes, please. Furthermore, if such bugfix cannot be described as >> anything but a simplification (with a correspondingly large diff), there >> should be another approach safer for the release branch. > > We must not get overly rigid about that. It takes extra work, and it > will not always be clear that it's worth the effort. Often it is, but > sometimes it isn't. We tend to decide on a case-by-case basis. > > Furthermore, please keep in mind that Yuan is both the principal author > and maintainer of our treesitter support. He's closer to the code than > anyone else, and is thus in the best position to make such judgement > calls. I see no reason to second-guess him here, myself. The burden of proof is on the author of the patch, who might be the most qualified person to comment on tree-sitter, but certainly not imenu, autoloads, or other areas of Emacs no less affected by this change. The bug fix in this change should have been separately installed on emacs-29, with the rest on master. > If there are any specific technical arguments for why this particular > change must not be installed on emacs-29, then let's hear them. Neither > generalizations nor administrative arguments will cut it, I think. I haven't heard any specific technical arguments as to why this change is safe. Rather, I'm the person who is frequently told that such specific statements regarding the safety of a large change are "famous last words"--which they are, all too often, so I have taken that advice to heart. > The above does not necessarily reflect the official line of the project. ??? I was summarizing what I myself have been told and observed over a certain length of time.