From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Tue, 19 Mar 2024 09:33:47 +0000 Message-ID: <87frwmsgzo.fsf@posteo.net> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <87il1jdhzd.fsf@posteo.net> <87le6f9m8b.fsf@jeremybryant.net> <87o7basp70.fsf@posteo.net> <87jzlysmvp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jeremy Bryant , Jeremy Bryant via "Emacs development discussions." , Eli Zaretskii , monnier@iro.umontreal.ca, j.j.oddie@gmail.com, stefankangas@gmail.com, jonas@bernoul.li To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 10:34:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmVrt-0000wU-Bf for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 10:34:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmVrB-0004Ts-Ri; Tue, 19 Mar 2024 05:34:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmVrA-0004TS-70 for emacs-devel@gnu.org; Tue, 19 Mar 2024 05:34:04 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmVqz-0006oK-4z for emacs-devel@gnu.org; Tue, 19 Mar 2024 05:34:03 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 24410240101 for ; Tue, 19 Mar 2024 10:33:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1710840830; bh=lqwFO9k1+m5MwCowXKmcJYdXbXsmLaCgCHfFjcD1rX0=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=hLA6sEKFn36XHRFheVI2jh9Yzp6NYE+D3al4vJSmwEqV32gVokiB0j4ndYxzIIV+q T11Tz0WeGn4OBFKLgfQtz1lofXz7nlZjD8lhIpboN3tW89+qhKjjhdL+ovnaw8Y6SN uR/Xj6ZVGsh8mDS9FxrjdwejrHkyXuVPr74enHhJgHEBmgekJ/BFPDTQDw1vkQbahA m+7n+4Xkex/fzq7jD3XRPRyd15HmCZK5BKBISGcCLj1e9XPEnmOlho3PIOMrWVuuWm A3AqKYy2LOGIKKcHXefTlxA9AshLscNCipb1x8pQr58rnpeZnvCfNuwfSlAFyVUs50 igTmKZijQHb/w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TzRP82Qqvz9rxR; Tue, 19 Mar 2024 10:33:48 +0100 (CET) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llmann?= =?utf-8?Q?=22's?= message of "Tue, 19 Mar 2024 08:30:02 +0100") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317185 Archived-At: Gerd M=C3=B6llmann writes: > Philip Kaludercic writes: > >> Gerd M=C3=B6llmann writes: >> >>> Philip Kaludercic writes: >>> >>>>> (add-hook 'c-mode-hook #'macrostep-c-mode-hook) >>>> >>>> This part is suspicious. First of all, it looks like one is adding a >>>> hook to a hook, but this would unconditionally modify >>>> c-mode-hook, which I don't think is reliable. Can we find some other >>>> way to update the variables, depending on the major mode? E.g. in >>>> macrostep.el one could try to intern (format "macrostep-%s-init" >>>> major-mode) and check if the symbol is fboundp? >>> >>> Also, it would be nice to support C++ and Objc, which we have in Emacs >>> (c-mode-common-hook). >> >> From what I understand, this feature is based on cmacexp, which in turn >> just uses cpp.=20=20 > > What's the problem using cpp? I don't know what Objc does, but in the case of C++ my understanding was that for example Templates were not expanded by C++. Of course, if that is not the intention, then never mind my comment. --=20 Philip Kaludercic on peregrine