unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 4d03f70b7f0 1/4: Correct doc strings for x-*-keysym
Date: Thu, 21 Mar 2024 20:42:52 +0800	[thread overview]
Message-ID: <87frwjpxgz.fsf@yahoo.com> (raw)
In-Reply-To: <865xxf3mi1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Mar 2024 12:30:46 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 16 Mar 2024 11:10:35 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>> 
>> >    DEFVAR_LISP ("x-ctrl-keysym", Vx_ctrl_keysym,
>> > -    doc: /* Which keys Emacs uses for the ctrl modifier.
>> > -This should be one of the symbols `ctrl', `alt', `hyper', `meta',
>> > -`super'.  For example, `ctrl' means use the Ctrl_L and Ctrl_R keysyms.
>> > -The default is nil, which is the same as `ctrl'.  */);
>> > +    doc: /* Which modifer value Emacs reports when Ctrl is depressed.
>> > +This should be one of the symbols `ctrl', `alt', `hyper', `meta', or
>> > +`super', representing a modifier to be reported in key events with the
>> > +Ctrl modifier (i.e. the keysym Ctrl_L or Ctrl_R) depressed.  */);
>> >    Vx_ctrl_keysym = Qnil;
>> 
>> This loses the information about the meaning of the default value of
>> nil, doesn't it?  This leaves the user who looks at the default value
>> confused as to what that means.
>> 
>> Also, the "depressed" part at the end of the last sentence is not
>> right: a modifier reported in a key event cannot be "depressed", it
>> can only be "set".  Right?
>
> Ping!  I don't see the changes you promised in the current master
> branch.

Oh right, this slipped my mind.  Thanks for the reminder.



      reply	other threads:[~2024-03-21 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171057401428.10492.2714593846955026456@vcs2.savannah.gnu.org>
     [not found] ` <20240316072654.D54C4C2BC6B@vcs2.savannah.gnu.org>
2024-03-16  9:10   ` master 4d03f70b7f0 1/4: Correct doc strings for x-*-keysym Eli Zaretskii
2024-03-16 10:43     ` Po Lu
2024-03-16 11:32       ` Eli Zaretskii
2024-03-21 10:30     ` Eli Zaretskii
2024-03-21 12:42       ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frwjpxgz.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).