From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eval EXEC Newsgroups: gmane.emacs.devel Subject: Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland Date: Fri, 06 Sep 2024 14:34:00 +0800 Message-ID: <87frqdz3xj.fsf@gmail.com> References: <8734mezkgo.fsf@gmail.com> <8634me447j.fsf@gnu.org> <861q1y437s.fsf@gnu.org> <86wmjq2mr2.fsf@gnu.org> <875xrars34.fsf@protonmail.com> <87h6aunilt.fsf@gmail.com> <87zfomqbgk.fsf@protonmail.com> <875xrani8k.fsf@gmail.com> <86bk122azc.fsf@gnu.org> <87v7zagcal.fsf@gmail.com> <867cbp3nw7.fsf@gnu.org> <87v7z9msrl.fsf@gmail.com> <874j6tqxyg.fsf@gmail.com> <86v7z91flo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="832"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pipcet@protonmail.com, gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 06 09:15:11 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smTBU-000AVn-9y for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Sep 2024 09:15:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smTAe-0003nP-3v; Fri, 06 Sep 2024 03:14:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smSXq-00078I-Tu for emacs-devel@gnu.org; Fri, 06 Sep 2024 02:34:12 -0400 Original-Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smSXl-0000mX-Nv; Fri, 06 Sep 2024 02:34:10 -0400 Original-Received: by mail-pg1-x541.google.com with SMTP id 41be03b00d2f7-7d4fbe62bf5so1222656a12.0; Thu, 05 Sep 2024 23:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725604443; x=1726209243; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=gjK2SW2ZqEr6oePmiYkUoTM9cpGJicgpA1x0urN1hEk=; b=FWlT4Qucn9qyp3twbRJZJZBfsKXQfjkqfRLP5Vu6agK5dk7vayU3D0UDTpiTv0FMsq InrXQbBmPGR7jVdW/LnEsQ87PTuva/5NvtsLrnazTvYfCqoJdElsg7gqtCtT3HnqpQgX RSLhQ70IPDzIr/79k1yYW6fvj6JM51W5hpBKFzMr/DfYqDKrXu4R+jCOwHz+BWFGf/yO Y3wFrJBSADXZ4ffzNNztvINB2hkwJlldcdK38y+r1yxW4YCrMdYDM4Jx78j6/wG6zr81 5UqOe2NtXfh+HZHmmAOA3zXtHduFIkD3pwQoEQbg6B8VSrRqMfZ1Y9NtACyDhVXHI1G+ 2G7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725604443; x=1726209243; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gjK2SW2ZqEr6oePmiYkUoTM9cpGJicgpA1x0urN1hEk=; b=CtERNXI8IYBDuPyIJxoThA5r5EvaP2p/HafHMLZZvr4sGsDsSCV+tZ1uJZa83gH0N1 qLoomnyfhYyjALQDrPUODZH6JxGAmHOMKawBK/REjSOF1gYA4AfizvWZGNjaM054dsvH jWCvIEWMvbrda0I0cotVXs9KbEnA/iOWBKqmYLeZbSypH+nHDbcPONtEYeiQc5SzON7w FuJHtTfzyps8xloPUqY3jOMs1jRbX5cWisADf1Tf98CG4/rejYW+h9XZ+PP8RUmLBSsw hHEztWgA2sBukP6M3WGk4+XqqEC5Q4cPlD2AfMwTYZI6NlLA/i5Ty3F6d5CEQfeZgbZn aPOw== X-Forwarded-Encrypted: i=1; AJvYcCWKr4Z/xTMdQJwOAYVHAHU/MPDEYsgWNXKPneBnute2d0RGSMSONXDwbmi72YBKGPwQdnwLi5A12ShzoQ==@gnu.org X-Gm-Message-State: AOJu0YyMfHv9NjmHFnBEjujNmIZYBb19kwuprjaIndeVy1H59fKiveeh 5DeSAkLw2sDxBweNMqYM9FQs9ef0nCoTTyuIT17/uP6a9hDobH7C808gq2ZhmylZJA== X-Google-Smtp-Source: AGHT+IFLhT9dKWehKltwz2xroyKiSixWQoJ42zAEdh+Q5rR2tuI+gUZqJuMe7pM1k6nnB0sfN5jusw== X-Received: by 2002:a05:6300:4044:b0:1ce:dd2e:d867 with SMTP id adf61e73a8af0-1cf1d1ed93amr1326085637.44.1725604442950; Thu, 05 Sep 2024 23:34:02 -0700 (PDT) Original-Received: from localhost (144.34.182.14.16clouds.com. [144.34.182.14]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7d50f75678bsm1502910a12.22.2024.09.05.23.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 23:34:02 -0700 (PDT) In-Reply-To: <86v7z91flo.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 06 Sep 2024 09:05:55 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=execvy@gmail.com; helo=mail-pg1-x541.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 06 Sep 2024 03:14:11 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323452 Archived-At: Eli Zaretskii writes: >> From: Eval EXEC >> Cc: pipcet@protonmail.com, gerd.moellmann@gmail.com, emacs-devel@gnu.org >> Date: Fri, 06 Sep 2024 11:10:15 +0800 >> >> Eval EXEC writes: >> >> > I recompiled commit 95a30325a84 (HEAD -> scratch/igc, origin/scratch/igc) >> > * src/igc.c (fix_frame): Correct the previous change. >> > >> > After testing, I believe the issue has been resolved. >> >> scratch/igc 95a30325 crash again: >> >> I use latest scratch/igc commit: * 95a30325a84 - (HEAD -> scratch/igc, origin/scratch/igc) * src/igc.c (fix_frame): Fix last change. (8 hours ago) >> >> #5 igc_assert_fail (file=, line=, msg=) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:209 > > It's an assertion violation, and it's too bad 'msg' is "optimized > out", because it's valuable information. > > This is a different problem, I think. > >> #9 0x0000000000690c05 in fix_lisp_obj (ss=ss@entry=0x7ffc7653e6f8, pobj=pobj@entry=0x7f08addd06b8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:975 >> off = >> client = >> base = 0x7f088a262a50 >> res = >> new_off = >> p = 0x7f08addd06b8 >> word = >> tag = >> _ss = 0x7ffc7653e6f8 >> _mps_zs = >> _mps_ufs = 36029896530599944 >> _mps_wt = >> _mps_w = >> #10 0x00000000006919f8 in fix_cons (cons=0x7f08addd06b0, ss=0x7ffc7653e6f8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:1751 >> res = >> _ss = 0x7ffc7653e6f8 >> _mps_zs = >> _mps_ufs = 36028797018972168 >> _mps_wt = >> _mps_w = > > So this says we hit the trouble while fixing a car of a cons: > > static mps_res_t > fix_cons (mps_ss_t ss, struct Lisp_Cons *cons) > { > MPS_SCAN_BEGIN (ss) > { > IGC_FIX12_OBJ (ss, &cons->u.s.car); <<<<<<<<<<<<<<<<<<<<< > IGC_FIX12_OBJ (ss, &cons->u.s.u.cdr); > } > MPS_SCAN_END (ss); > return MPS_RES_OK; > } > > static mps_res_t > fix_lisp_obj (mps_ss_t ss, Lisp_Object *pobj) > { > MPS_SCAN_BEGIN (ss) > { > mps_word_t *p = (mps_word_t *) pobj; > mps_word_t word = *p; > > /* Quickly rule out Qnil, and prevent subtraxting from a > null pointer. */ > if (word == 0) > return MPS_RES_OK; > > mps_word_t tag = word & IGC_TAG_MASK; > if (tag == Lisp_Int0 || tag == Lisp_Int1) > return MPS_RES_OK; > else if (tag == Lisp_Type_Unused0) > emacs_abort (); > > if (tag == Lisp_Symbol) > { > ptrdiff_t off = word ^ tag; > mps_addr_t client = (mps_addr_t) ((char *) lispsym + off); > mps_addr_t base = client; > if (MPS_FIX1 (ss, base)) > { > mps_res_t res = MPS_FIX2 (ss, &base); <<<<<<<<<<<<<<<<<<< > > I guess it would be interesting to see what was the cons and what was > the symbol that was its car? > > Like this: > > (gdb) frame 9 > (gdb) p *pobj > (gdb) xtype > (gdb) xsymbol > (gdb) frame 10 > (gdb) p *cons > (gdb) xcons > (gdb) p *xcons > (gdb) xcdr > (gdb) xtype It's (gdb) frame 9 #9 0x0000000000690c05 in fix_lisp_obj (ss=ss@entry=0x7ffc7653e6f8, pobj=pobj@entry=0x7f08addd06b8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:975 975 mps_res_t res = MPS_FIX2 (ss, &base); (gdb) p *pobj $1 = XIL(0x7f0889546b70) (gdb) xtype Lisp_Symbol (gdb) xsymbol $2 = (struct Lisp_Symbol *) 0x7f088a262a50 Cannot access memory at address 0x4c78 (gdb) frame 10 #10 0x00000000006919f8 in fix_cons (cons=0x7f08addd06b0, ss=0x7ffc7653e6f8) at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:1751 1751 IGC_FIX12_OBJ (ss, &cons->u.s.car); (gdb) p *cons $3 = { gc_header = { v = 16630752781, gcaligned = 13 '\r' }, u = { s = { car = XIL(0x7f0889546b70), u = { cdr = XIL(0x7f08936d87d3), chain = 0x7f08936d87d3 } }, gcaligned = 112 'p' } } (gdb) xcons Invalid cast. (gdb) p *xcons No symbol "xcons" in current context. (gdb) xcdr Invalid cast. (gdb) xtype Invalid cast. Thanks Eval Exec --