From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: hyperdrive-org-transclusion Date: Sun, 22 Sep 2024 22:49:10 -0700 Message-ID: <87frpqhqcp.fsf@ushin.org> References: <87ed5lzytw.fsf@ushin.org> <87a5fz8sii.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16863"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List , Adam Porter , Paula Maas , Protesilaos Stavrou , Noboru Ota To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 13:09:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssgwh-0004Er-SW for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 13:09:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssgwH-0000zL-5z; Mon, 23 Sep 2024 07:09:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssbwt-0000TU-GX for emacs-devel@gnu.org; Mon, 23 Sep 2024 01:49:27 -0400 Original-Received: from out-183.mta1.migadu.com ([2001:41d0:203:375::b7]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssbwo-0002JR-S8 for emacs-devel@gnu.org; Mon, 23 Sep 2024 01:49:27 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ushin.org; s=key1; t=1727070559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Dz0JjueTstmRga4KF4K8nTb6jd+SB9a6AwAI0F3YV0=; b=Sz/5ILXvfjBjgKdi4rr641YQmuJT6ibuNTmdlVtkCP4ghPYz4Y8+g3C0v/3zlQzhQpex4A gWmrrxrrM5q7aEB2eWvpJXxhHOeaogO8xBp4OO+Uh6qtzkRliI5D1v3VD/SPWdgtkidLix 5QzW52brDDHIAdlnZ4Twu9AhE1yd+TTHOWf6C0OFBAeYG9IfxW22S/1qQW+0PULNbdBUEv M+2i9759kYlUJ7cMx+GWgRWlI/G5v8/9l7sO62eWWWCrsYF+T3gHns2D2+DYokVMGDxLoG jVg64eWu4rnwgTE8UszHYQXRKK2kWn29N4RQQlDxpnZnPPAO2tXEZqljxslNdw== In-Reply-To: <87a5fz8sii.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 22 Sep 2024 18:15:01 +0000") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b7; envelope-from=joseph@ushin.org; helo=out-183.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 23 Sep 2024 07:09:00 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323952 Archived-At: --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Joseph Turner writes: > >> Hello all, > > Hey, sorry for the delay, > >> extends >> org-transclusion by allowing content served over the hyper:// network to >> be transcluded using hyperdrive.el. > > Code/content-wise, I cannot really comment on anything as it is based on > multiple layers of API that I am not familiar with. That being said, > the (display-fill-column-indicator-mode) in the .dir-locals.el file is > very unusual and something I think you should avoid. Also, an > .elpaignore file that would exclude some of the files that are only > interesting to contributors and maintainers would be nice. Thank you for the review!! The (display-fill-column-indicator-mode) addition was something that we settled on in the hyperdrive.el project last year as a way to remind contributors to fill code before committing. I'm open to removing it. Would you elaborate on the reasons to avoid it? >> + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" >> + :readme "README.org" > > This file is automatically detected, we just choose to ignore README.md > files by default. Good to know. I've removed that line in the attached patch. >> + :news "CHANGELOG.org") > > Fun fact: If you call the file NEWS.org, it will be automatically detected. Good to know. I'd like to leave CHANGELOG.org as it is for now. Thank you!! Joseph --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-elpa-packages-hyperdrive-org-transclusion-New-packag.patch >From 931e466053437a727fea76005b368f436cbf80e9 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sun, 22 Sep 2024 22:46:57 -0700 Subject: [PATCH] * elpa-packages (hyperdrive-org-transclusion): New package --- elpa-packages | 3 +++ 1 file changed, 3 insertions(+) diff --git a/elpa-packages b/elpa-packages index 0ea8b159a6..3ddbfec540 100644 --- a/elpa-packages +++ b/elpa-packages @@ -402,6 +402,9 @@ :release-branch "stable" :doc "doc/hyperdrive.org") + (hyperdrive-org-transclusion :url "https://git.sr.ht/~ushin/hyperdrive-org-transclusion" + :news "CHANGELOG.org") + (idle-highlight-mode :url "https://codeberg.org/ideasman42/emacs-idle-highlight-mode" :ignored-files (".elisp-autofmt")) -- 2.46.0 --=-=-=--