From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Wed, 18 Dec 2024 16:25:08 +0000 Message-ID: <87frml9cy4.fsf@protonmail.com> References: <86seqmm9dq.fsf@gnu.org> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11366"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 17:56:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNxM3-0002mh-EM for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 17:56:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNxLY-00083g-DY; Wed, 18 Dec 2024 11:56:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNwrN-000804-OX for emacs-devel@gnu.org; Wed, 18 Dec 2024 11:25:18 -0500 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNwrL-0007hu-JW; Wed, 18 Dec 2024 11:25:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1734539111; x=1734798311; bh=ruFdqEYNQ5temaNvQmbiz4cv/9nuZL5hmTuj7r9Hlf0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=P/Sh+LFfm3K12KdckWB0n2/4vnt3ZBNx4UkzZh1XZ4L+dFQ78YRIkshIx9uPAziYG 32FhfEKqexRUdm/7hgSAwqdg/JzBznOId3FU9tnHsFF9upOm4ATKlGPCBPI9/fy/2+ IjlZnE5N24xgQ7KhW8drvEOAGqAfLpDH7bgz3ONmLIDSIS0DQ5derslnUmBUO8qNBJ tscwxd5yI0flIJJ7XYbO5JgGuxzMW68xvLqQXxYTqUuWN6yi3LLa0P4NMG24I1PBRR 7mOtHb+Ke+ToxnwXI1M60UQQA/WklTLmHGNDfMwsHYsdf5IBiE8eDGFtzSKYVoLQyo XrmzSmaWgC3Hg== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: b5c55fa5909addc196d1affb6da204a84d5fa82f Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-1.116, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 18 Dec 2024 11:56:24 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326670 Archived-At: Pip Cet writes: > IOW, the old code happened not to run into this problem because > lambda-fixup was pure, and we never applied the sanity checks to the > pure section. Just to be clear: the code on master is fine. I misunderstood it when modifying it for purespace removal, resulting in my bug which Gerd discovered and fixed. The code on no-purespace is also fine now, but it's Andrea's call whether he wants some of the checking code restored, and how. > My suggestion is to fix the "sanity check" on the master branch, change > it to apply to pure relocs there, and restore the fixed check on > scratch/no-purespace afterwards. Please ignore that. My suggestion is to EXTEND the sanity check on the master branch to cover pure and impure relocs, and restore the EXTENDED check before merging scratch/no-purespace. There is no bug to fix on master. Pip