unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: How can I undo a change from a modification-hook?
Date: Wed, 26 Apr 2017 09:45:50 -0400	[thread overview]
Message-ID: <87fd6638-f46a-95f2-8b70-f271f5daeb63@gmail.com> (raw)
In-Reply-To: <jwvshkvcqik.fsf-monnier+gmane.emacs.devel@gnu.org>

> Technically you can, but it's a bit messy and will likely not be
> 100% reliable.  Personally, in your case, I wouldn't bother doing it,
> but here's how I'd do it otherwise:

Thanks for the answer! The context is Proof General: it's very annoying that running whitespace-cleanup retracts what looks like arbitrary sections of the buffer.

On 2017-04-26 08:26, Stefan Monnier wrote:
> [ and while
>   you're there, check that the beg/end/len is within the announces
>   beg/end stashed earlier, and if it's not just don't do anything
>   since it means the stash buffer-undo-list is likely unrelated.  ]

This part worries me.  Could you clarify when this would happen?
Not doing anything is risky, because it puts the buffer in an inconsistent state wrt the subprocess :/

Thanks!



  reply	other threads:[~2017-04-26 13:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  7:02 How can I undo a change from a modification-hook? Clément Pit--Claudel
2017-04-26 12:26 ` Stefan Monnier
2017-04-26 13:45   ` Clément Pit-Claudel [this message]
2017-04-26 13:52     ` Stefan Monnier
2017-04-26 14:23       ` Clément Pit-Claudel
2017-04-26 14:51         ` Stefan Monnier
2017-04-26 16:38           ` Clément Pit-Claudel
2017-04-26 18:43             ` Stefan Monnier
2017-04-26 19:02               ` Clément Pit-Claudel
2017-04-27 12:48                 ` Stefan Monnier
2017-04-27 12:58                   ` Clément Pit-Claudel
2017-04-27 17:36                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fd6638-f46a-95f2-8b70-f271f5daeb63@gmail.com \
    --to=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).