[offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[Richard Stallman]

Could you please DTRT and ack?

Others: John has not responded for 2 weeks, so if someone else
can do this, it would be useful.

------- Start of forwarded message -------
To: emacs-pretest-bug@gnu.org
From: Eric Hanchrow <offby1@blarg.net>
Date: Fri, 11 Aug 2006 08:55:25 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: ibuffer's "s v" doesn't redraw buffer
X-Spam-Status: No, score=0.1 required=5.0 tests=FORGED_RCVD_HELO 
	autolearn=failed version=3.0.4


* I started emacs with "emacs -Q"
* I loaded ibuffer: M-x load-library<return>ibuffer<return>
* I ran ibuffer: M-x ibuffer<return>
* I sorted the buffer by major mode: s m

I note that after I type the "m", the buffer is immediately redrawn,
with the entries in their new order.

* I sorted the buffer by recency: s v

I note that the buffer hasn't changed.

* I force the buffer to change: g

Now the buffer looks the way I'd expect it to.
If emacs crashed, and you have the emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/src/emacs-cvs/etc/DEBUG for instructions.


In GNU Emacs 22.0.50.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2006-07-27 on debian
X server distributor `The X.Org Foundation', version 11.0.70000000
configured using `configure '--enable-maintainer-mode''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
M-x r e p o r t - e m a c s - b u f <tab> <return> 
<backspace> g <tab> <return>

Recent messages:
(/usr/local/src/emacs-cvs/src/emacs -Q)
For information about the GNU Project and its goals, type C-h C-p.
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done

- -- 
Two degrees in be-bop, a Ph.D. in swing
        -- Lowell George, Fred Martin


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[Chong Yidong]

> * I started emacs with "emacs -Q"
> * I loaded ibuffer: M-x load-library<return>ibuffer<return>
> * I ran ibuffer: M-x ibuffer<return>
> * I sorted the buffer by major mode: s m
>
> I note that after I type the "m", the buffer is immediately redrawn,
> with the entries in their new order.
>
> * I sorted the buffer by recency: s v
>
> I note that the buffer hasn't changed.

The problem was that ibuffer-do-sort-by-recency is not defined with
define-ibuffer-sorter, for some reason obscure to me.  Therefore it is
not on ibuffer-sorting-functions-alist, so the call to
ibuffer-sort-bufferlist in ibuffer-redisplay-engine fails (the error
is caught by an unwind-protect).

This hack will remove the bug, but I'm not familiar enough with
ibuffer to know if it's the right approach.

*** emacs/lisp/ibuffer.el.~1.83.~	2006-07-24 11:48:53.000000000 -0400
--- emacs/lisp/ibuffer.el	2006-08-25 18:22:00.000000000 -0400
***************
*** 1972,1983 ****
  		(not (eq ibuffer-buf buf))))))
  
  ;; This function is a special case; it's not defined by
! ;; `ibuffer-define-sorter'.
  (defun ibuffer-do-sort-by-recency ()
    "Sort the buffers by last view time."
    (interactive)
    (setq ibuffer-sorting-mode 'recency)
!   (ibuffer-redisplay t))
  
  (defun ibuffer-update-format ()
    (when (null ibuffer-current-format)
--- 1972,1983 ----
  		(not (eq ibuffer-buf buf))))))
  
  ;; This function is a special case; it's not defined by
! ;; `define-ibuffer-sorter'.
  (defun ibuffer-do-sort-by-recency ()
    "Sort the buffers by last view time."
    (interactive)
    (setq ibuffer-sorting-mode 'recency)
!   (ibuffer-update nil t))
  
  (defun ibuffer-update-format ()
    (when (null ibuffer-current-format)

Re: [offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[Richard Stallman]

    This hack will remove the bug, but I'm not familiar enough with
    ibuffer to know if it's the right approach.

If John does not respond in 2 weeks, would you please install your
patch?  He can always change it later if it isn't right.

Re: [offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[John Paul Wallington]

On 8/25/06, Chong Yidong <cyd@stupidchicken.com> wrote:
> > * I started emacs with "emacs -Q"
> > * I loaded ibuffer: M-x load-library<return>ibuffer<return>
> > * I ran ibuffer: M-x ibuffer<return>
> > * I sorted the buffer by major mode: s m
> >
> > I note that after I type the "m", the buffer is immediately redrawn,
> > with the entries in their new order.
> >
> > * I sorted the buffer by recency: s v
> >
> > I note that the buffer hasn't changed.
>
> The problem was that ibuffer-do-sort-by-recency is not defined with
> define-ibuffer-sorter, for some reason obscure to me.  Therefore it is
> not on ibuffer-sorting-functions-alist, so the call to
> ibuffer-sort-bufferlist in ibuffer-redisplay-engine fails (the error
> is caught by an unwind-protect).
>
> This hack will remove the bug, but I'm not familiar enough with
> ibuffer to know if it's the right approach.
>
> *** emacs/lisp/ibuffer.el.~1.83.~       2006-07-24 11:48:53.000000000 -0400
> --- emacs/lisp/ibuffer.el       2006-08-25 18:22:00.000000000 -0400
> ***************
> *** 1972,1983 ****
>                (not (eq ibuffer-buf buf))))))
>
>  ;; This function is a special case; it's not defined by
> ! ;; `ibuffer-define-sorter'.
>  (defun ibuffer-do-sort-by-recency ()
>    "Sort the buffers by last view time."
>    (interactive)
>    (setq ibuffer-sorting-mode 'recency)
> !   (ibuffer-redisplay t))
>
>  (defun ibuffer-update-format ()
>    (when (null ibuffer-current-format)
> --- 1972,1983 ----
>                (not (eq ibuffer-buf buf))))))
>
>  ;; This function is a special case; it's not defined by
> ! ;; `define-ibuffer-sorter'.
>  (defun ibuffer-do-sort-by-recency ()
>    "Sort the buffers by last view time."
>    (interactive)
>    (setq ibuffer-sorting-mode 'recency)
> !   (ibuffer-update nil t))
>
>  (defun ibuffer-update-format ()
>    (when (null ibuffer-current-format)

That change looks good, although I haven't tested it.  Could you
please install it?

Re: [offby1@blarg.net: ibuffer's "s v" doesn't redraw buffer]

[Chong Yidong]

"John Paul Wallington" <jpw@pobox.com> writes:

>> The problem was that ibuffer-do-sort-by-recency is not defined with
>> define-ibuffer-sorter, for some reason obscure to me.  Therefore it is
>> not on ibuffer-sorting-functions-alist, so the call to
>> ibuffer-sort-bufferlist in ibuffer-redisplay-engine fails (the error
>> is caught by an unwind-protect).
>>
>> This hack will remove the bug, but I'm not familiar enough with
>> ibuffer to know if it's the right approach.
>
> That change looks good, although I haven't tested it.  Could you
> please install it?

Done.